From: Pedro Alves <pedro@palves.net>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] gdbsupport: Fix config.status dependency
Date: Thu, 8 Sep 2022 11:23:34 +0100 [thread overview]
Message-ID: <bb79d335-b10d-428d-6a51-2e6a429866cc@palves.net> (raw)
In-Reply-To: <363d921e5d135e1e8d964235add673beba7cdd21.1662617054.git.research_trasio@irq.a4lg.com>
On 2022-09-08 7:04 a.m., Tsukasa OI wrote:
> Commit 171fba11ab27 ("Make GDBserver abort on internal error in development mode")
> created a new substitution CONFIG_STATUS_DEPENDENCIES but this is used by
> Makefile.in (which is not regenerated by that commit). After regenerating
> it, it is found that CONFIG_STATUS_DEPENDENCIES value is not valid, making
> gdbsupport fail to build.
>
> Since the CONFIG_STATUS_DEPENDENCIES value is used in the Makefile, macro
> substitution must have a Makefile format but commit 171fba11ab27 used shell
> format "$srcdir/../bfd/development.sh".
>
> This commit fixes this issue by substituting "$srcdir" (shell format) to
> "$(srcdir)" (Makefile format). It preserves the dependency as Pedro
> intended and fixes the build problem.
>
Whoops.
> It also regenerates corresponding files with the maintainer mode.
>
> gdbsupport/ChangeLog:
>
> * configure.ac: Fix config.status dependency.
> * Makefile.in: Regenerate.
> * configure: Regenerate.
This is OK, please push.
Thanks,
Pedro Alves
prev parent reply other threads:[~2022-09-08 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 6:04 [PATCH 0/1] " Tsukasa OI
2022-09-08 6:04 ` [PATCH 1/1] " Tsukasa OI
2022-09-08 10:23 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb79d335-b10d-428d-6a51-2e6a429866cc@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).