From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: [PATCH 0/1] gdbsupport: Fix config.status dependency
Date: Thu, 8 Sep 2022 06:04:19 +0000 [thread overview]
Message-ID: <cover.1662617054.git.research_trasio@irq.a4lg.com> (raw)
Hello,
While I'm digging the build pipeline using the maintainer mode, I found
something that will prevent building gdbsupport (luckily, it didn't occur by
another mistake).
Commit 171fba11ab27 ("Make GDBserver abort on internal error in development
mode") created a new substitution CONFIG_STATUS_DEPENDENCIES but this is
used by Makefile.in (which is not regenerated by that commit). This is not
good but prevented the problem I'll describe later.
After regenerating it, it is found that CONFIG_STATUS_DEPENDENCIES value is
not valid, making gdbsupport fail to build.
Since the CONFIG_STATUS_DEPENDENCIES value is used in the Makefile, macro
substitution must have a Makefile format but commit 171fba11ab27 used shell
format "$srcdir/../bfd/development.sh".
PATCH 1/1 fixes this issue by substituting "$srcdir" (shell format) to
"$(srcdir)" (Makefile format). It preserves the dependency as Pedro
intended and fixes the build problem.
It also regenerates corresponding files with the maintainer mode.
Thanks,
Tsukasa
Tsukasa OI (1):
gdbsupport: Fix config.status dependency
gdbsupport/Makefile.in | 1 +
gdbsupport/configure | 2 +-
gdbsupport/configure.ac | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
base-commit: f42546b6cc7468ac7d929181ed7b965ab60958ac
--
2.34.1
next reply other threads:[~2022-09-08 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 6:04 Tsukasa OI [this message]
2022-09-08 6:04 ` [PATCH 1/1] " Tsukasa OI
2022-09-08 10:23 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1662617054.git.research_trasio@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).