From: Simon Marchi <simon.marchi@polymtl.ca>
To: Luis Machado <luis.machado@arm.com>, gdb-patches@sourceware.org
Cc: thiago.bauermann@linaro.org
Subject: Re: [PATCH v5 10/16] [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes
Date: Fri, 8 Sep 2023 11:51:32 -0400 [thread overview]
Message-ID: <bbd36ee6-2719-473c-8c33-44c877ad1254@polymtl.ca> (raw)
In-Reply-To: <08ceb244-9694-46a3-b656-1c169a31bfb4@polymtl.ca>
On 9/8/23 11:48, Simon Marchi wrote:
> On 9/8/23 07:08, Luis Machado via Gdb-patches wrote:
>> It would be nice to have a global maintainer go through this one, as it touches a small part of generic gdb code.
>
> I don't have time to go in depth in the AArch64-specific bits, but for
> the trad-frame changes:
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> Simon
Maybe a minor comment I forgot to mention: instead of defining a new
frame_prev_arch_ftype typedef, can we include frame-unwind.h? The
intention of the new prev_arch is really just to forward it to the
unwinder created around the tramp_frame, so I think it would make sense
to do so.
Simon
next prev parent reply other threads:[~2023-09-08 15:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 15:20 [PATCH v5 00/16] SME support for AArch64 gdb/gdbserver on Linux Luis Machado
2023-09-07 15:20 ` [PATCH v5 01/16] [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux Luis Machado
2023-09-07 15:20 ` [PATCH v5 02/16] [gdb/aarch64] refactor: Rename SVE-specific files Luis Machado
2023-09-07 15:20 ` [PATCH v5 03/16] [gdb/gdbserver] refactor: Simplify SVE interface to read/write registers Luis Machado
2023-09-07 15:20 ` [PATCH v5 04/16] [gdb/aarch64] sve: Fix return command when using V registers in a SVE-enabled target Luis Machado
2023-09-07 15:20 ` [PATCH v5 05/16] [gdb/aarch64] sme: Enable SME registers and pseudo-registers Luis Machado
2023-09-07 15:20 ` [PATCH v5 06/16] [gdbserver/aarch64] refactor: Adjust expedited registers dynamically Luis Machado
2023-09-08 15:35 ` Simon Marchi
2023-09-08 16:00 ` Luis Machado
2023-09-08 16:52 ` Simon Marchi
2023-09-07 15:20 ` [PATCH v5 07/16] [gdbserver/aarch64] sme: Add support for SME Luis Machado
2023-09-07 15:20 ` [PATCH v5 08/16] [gdb/aarch64] sve: Fix signal frame z/v register restore Luis Machado
2023-09-07 15:20 ` [PATCH v5 09/16] [gdb/aarch64] sme: Signal frame support Luis Machado
2023-09-07 15:20 ` [PATCH v5 10/16] [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes Luis Machado
2023-09-08 11:08 ` Luis Machado
2023-09-08 15:48 ` Simon Marchi
2023-09-08 15:51 ` Simon Marchi [this message]
2023-09-08 15:51 ` Luis Machado
2023-09-08 15:59 ` Simon Marchi
2023-09-07 15:20 ` [PATCH v5 11/16] [gdb/aarch64] sme: Support TPIDR2 signal frame context Luis Machado
2023-09-07 15:20 ` [PATCH v5 12/16] [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping register state to core files Luis Machado
2023-09-08 11:09 ` Luis Machado
2023-09-08 15:58 ` Simon Marchi
2023-09-08 16:02 ` Simon Marchi
2023-09-08 16:05 ` Luis Machado
2023-09-07 15:20 ` [PATCH v5 13/16] [gdb/generic] corefile/bug: Fixup (gcore) core file target description reading order Luis Machado
2023-09-08 11:10 ` Luis Machado
2023-09-08 17:10 ` Simon Marchi
2023-09-12 8:49 ` Luis Machado
2023-09-13 13:50 ` Simon Marchi
2023-09-13 13:57 ` Luis Machado
2023-09-07 15:20 ` [PATCH v5 14/16] [gdb/aarch64] sme: Core file support for Linux Luis Machado
2023-09-07 15:20 ` [PATCH v5 15/16] [gdb/testsuite] sme: Add SVE/SME testcases Luis Machado
2023-09-07 15:20 ` [PATCH v5 16/16] [gdb/docs] sme: Document SME registers and features Luis Machado
2023-09-13 3:03 ` [PATCH v5 00/16] SME support for AArch64 gdb/gdbserver on Linux Thiago Jung Bauermann
2023-09-13 10:20 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbd36ee6-2719-473c-8c33-44c877ad1254@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).