From: Tom de Vries <tdevries@suse.de>
To: Bruno Larsen <blarsen@redhat.com>, Tom Tromey <tom@tromey.com>,
Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PINGv4][PATCH v4 0/5] Smart pointer wrapper for frame_info
Date: Mon, 10 Oct 2022 12:46:25 +0200 [thread overview]
Message-ID: <c40380d4-2076-b23e-7805-ef5b05e1008f@suse.de> (raw)
In-Reply-To: <472ae014-5764-51f5-caf7-352fa543a530@redhat.com>
On 10/10/22 09:55, Bruno Larsen via Gdb-patches wrote:
> On 07/10/2022 21:35, Tom Tromey wrote:
>>>>>>> "Bruno" == Bruno Larsen via Gdb-patches
>>>>>>> <gdb-patches@sourceware.org> writes:
>> Bruno> ping!
>>
>> I had a couple minor nits on patch #5, but you can just fix those and
>> push it all without re-sending. Thank you for doing this.
> Thanks! I'll rebase it and push the series in a second
>
I'm seeing a build breaker on x86_64-linux:
...
/home/vries/gdb_versions/devel/src/gdb/guile/scm-frame.c: In function
‘int frscm_eq_frame_smob(const void*, const void*)’:
/home/vries/gdb_versions/devel/src/gdb/guile/scm-frame.c:137:11: error:
‘frame_id_eq’ was not declared in this scope
return (frame_id_eq (a->frame_id, b->frame_id)
^~~~~~~~~~~
...
Thanks,
- Tom
next prev parent reply other threads:[~2022-10-10 10:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 10:08 [PATCH " Bruno Larsen
2022-08-30 10:08 ` [PATCH v4 1/5] Remove frame_id_eq Bruno Larsen
2022-08-30 10:08 ` [PATCH v4 2/5] Introduce frame_info_ptr smart pointer class Bruno Larsen
2022-08-30 10:08 ` [PATCH v4 3/5] Change GDB to use frame_info_ptr Bruno Larsen
2022-08-30 10:08 ` [PATCH v4 4/5] Continue making GDB " Bruno Larsen
2022-08-30 10:08 ` [PATCH v4 5/5] gdb/frame: Add reinflation method for frame_info_ptr Bruno Larsen
2022-10-07 19:34 ` Tom Tromey
2022-10-10 7:54 ` Bruno Larsen
2022-10-11 7:58 ` Tom de Vries
2022-10-11 9:42 ` Bruno Larsen
2022-09-13 8:06 ` [Ping][PATCH v4 0/5] Smart pointer wrapper for frame_info Bruno Larsen
2022-09-21 15:39 ` [PINGv2][PATCH " Bruno Larsen
2022-09-29 7:01 ` [PINGv3][PATCH " Bruno Larsen
2022-10-05 9:58 ` [PINGv4][PATCH " Bruno Larsen
2022-10-07 19:35 ` Tom Tromey
2022-10-10 7:55 ` Bruno Larsen
2022-10-10 10:46 ` Tom de Vries [this message]
2022-10-10 12:04 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40380d4-2076-b23e-7805-ef5b05e1008f@suse.de \
--to=tdevries@suse.de \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).