Re: [PATCH 5/5] gdb: make target_desc_info_from_user_p a method of target_desc_info

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2/6/23 13:41, Pedro Alves wrote:
> On 2023-02-03 2:21 p.m., Simon Marchi via Gdb-patches wrote:
>> --- a/gdb/inferior.h
>> +++ b/gdb/inferior.h
>> @@ -345,6 +345,11 @@ extern void switch_to_inferior_no_thread (inferior *inf);
>>  
>>  struct target_desc_info
>>  {
>> +  /* Returns true if INFO indicates the target description had been supplied by
>> +     the user.  */
> 
> There is no INFO anymore.

Ah, thanks.  I pushed this fix.


From f9b677528fdde6b1d5f402b75db2efcbe62c93d8 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Mon, 6 Feb 2023 14:12:27 -0500
Subject: [PATCH] gdb: adjust comment on target_desc_info::from_user_p

Remove the stale reference to INFO, which is now "this target
description info" now.

Change-Id: I35dbdb089048ed7cfffe730d3134ee391b176abf
---
 gdb/inferior.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/inferior.h b/gdb/inferior.h
index bac483f0f78d..72034cc4ffbc 100644
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -345,7 +345,7 @@ extern void switch_to_inferior_no_thread (inferior *inf);
 
 struct target_desc_info
 {
-  /* Returns true if INFO indicates the target description had been supplied by
+  /* Returns true if this target description information has been supplied by
      the user.  */
   bool from_user_p ()
   { return !this->filename.empty (); }

base-commit: 85df9457b72e4a198b4edfc908017612fca59509
-- 
2.39.1