Re: [PATCH 3/5] gdb: remove get_tdesc_info

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2/3/23 10:53, Andrew Burgess wrote:
> Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> Remove this function, since it's now a trivial access to
>> inferior::tdesc_info.
>>
>> Change-Id: I3e88a8214034f1a4163420b434be11f51eef462c
>> ---
>>  gdb/target-descriptions.c | 28 ++++++++++------------------
>>  1 file changed, 10 insertions(+), 18 deletions(-)
>>
>> diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c
>> index 049e42c7ea77..0561a8098c5c 100644
>> --- a/gdb/target-descriptions.c
>> +++ b/gdb/target-descriptions.c
>> @@ -436,14 +436,6 @@ struct tdesc_arch_data
>>    gdbarch_register_reggroup_p_ftype *pseudo_register_reggroup_p = NULL;
>>  };
>>  
>> -/* Get the inferior INF's target description info.  */
>> -
>> -static struct target_desc_info *
>> -get_tdesc_info (struct inferior *inf)
>> -{
>> -  return &inf->tdesc_info;
>> -}
>> -
>>  /* A handle for architecture-specific data associated with the
>>     target description (see struct tdesc_arch_data).  */
>>  
>> @@ -472,8 +464,8 @@ target_desc_info_from_user_p (struct target_desc_info *info)
>>  void
>>  copy_inferior_target_desc_info (struct inferior *destinf, struct inferior *srcinf)
>>  {
>> -  struct target_desc_info *src = get_tdesc_info (srcinf);
>> -  struct target_desc_info *dest = get_tdesc_info (destinf);
>> +  struct target_desc_info *src = &srcinf->tdesc_info;
>> +  struct target_desc_info *dest = &destinf->tdesc_info;
>>  
>>    *dest = *src;
> 
> Would:
> 
>   destinf->tdesc_info = srcinf->tdesc_info;
> 
> not be better now?

For others: this disappears in the next patch anyway.

Simon