Re: [PATCHv2 1/3] gdb: work around prompt corruption caused by bracketed-paste-mode

[Simon Marchi <simon.marchi@polymtl.ca>]

> Thanks for the awesome steps to reproduce!  This made it super easy to
> track down the problem.
> 
> Basically the problem is that I only took readline 8+ into account
> when writing the test, this spin of ubuntu is on readline 7.
> 
> The patch below changes the test FAIL into a KFAIL, which, if you were
> on readline 8 would be the best we could do.
> 
> But given you're on readline 7, we should be able to do better,
> getting this to a PASS!  But that will require changes to GDB itself.
> 
> I'd like to propose that first we merge the patch below, this removes
> the FAIL, then next week I'll post a follow on patch for GDB that
> should get this test PASSing for readline 7.
> 
> Thoughts?

Hi,

I am fine with the patch below.  Unfortunately I am not up to speed on
what this issue with the prompt was, so I can't really help further.
Thanks for coming back with a "fix" quickly, that helps.

Just one nit in the commit message below.

> commit 7a0add556420e2ef814a6cd58501a832fdb1fb90
> Author: Andrew Burgess <aburgess@redhat.com>
> Date:   Sat Mar 26 13:41:33 2022 +0000
> 
>     gdb/testsuite: fix test failure when building against readline v7
>     
>     The test added in the commit:
>     
>       commit a6b413d24ccc5d76179bab866834e11fd6fec294
>       Date:   Fri Mar 11 14:44:03 2022 +0000
>     
>           gdb: work around prompt corruption caused by bracketed-paste-mode
>     
>     Was not written with readline 7 in mind, only readline 8+.  Between
>     readline 7 and 8 the escape sequence used to disable bracketed paste
>     mode changed, an additional '\r' character was added to the end.  In
>     fact, it was the addition of this '\r' character that triggered the
>     issue for which the above commit is part of the solution.
>     
>     Anyway, the test tries to spot the case where the output from GDB is
>     not perfect, but does have the above work around applied.  However,
>     the pattern in the test assume that the problematic '\r' will be

assume -> assumes

Simon