public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Make gdb.ada/ptype_tagged_param.exp pass
Date: Fri, 20 Jan 2023 12:00:10 -0500	[thread overview]
Message-ID: <c9f12e2e-259e-613d-eb8f-0c3359812cb7@simark.ca> (raw)
In-Reply-To: <20230119163150.492922-1-tromey@adacore.com>



On 1/19/23 11:31, Tom Tromey via Gdb-patches wrote:
> gdb.ada/ptype_tagged_param.exp is failing for me on x86-64 Fedora 36.
> However, it's actually generating the correct output -- it is just
> that the test thinks that the "ptype" will not work because I do not
> have the GNAT debuginfo installed.
> 
> This patch changes the code to accept either result, and then to issue
> a kfail as appropriate.

I introduced that code in 2019, saying:

    Currently the test fails when when running against a GNAT runtime
    without debug info.  This is the case, for example, on Arch Linux using
    the distribution package.

However, now, on the same system (but obviously not the same package
versions, as I keep it up to date), I see the same as you:

    (gdb) ptype s
    type = <ref> new pck.shape with record
        r: integer;
    end record
    (gdb) FAIL: gdb.ada/ptype_tagged_param.exp: ptype s, without debug info

Do you know what could have changed?  New improved DWARF info from a
newer compiler?

In any case, your change LGTM, since it will still cause a fail if we do
have debug info but see the bad output.

Simon

  reply	other threads:[~2023-01-20 17:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 16:31 Tom Tromey
2023-01-20 17:00 ` Simon Marchi [this message]
2023-01-20 17:05   ` Tom Tromey
2023-01-27  5:58     ` Simon Marchi
2023-01-27 14:11       ` Tom Tromey
2023-01-27 15:56         ` Simon Marchi
2023-01-27 17:24           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9f12e2e-259e-613d-eb8f-0c3359812cb7@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).