public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>,
	Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make gdb.ada/ptype_tagged_param.exp pass
Date: Fri, 27 Jan 2023 00:58:29 -0500	[thread overview]
Message-ID: <fbb0f6ba-f164-af53-eaf0-b09255f0308a@simark.ca> (raw)
In-Reply-To: <874jslyw58.fsf@tromey.com>

On 1/20/23 12:05, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Do you know what could have changed?  New improved DWARF info from a
> Simon> newer compiler?
> 
> Possibly, but I don't really know, and I actually don't remember all
> that much about how tagged types work under the hood.
> 
> Simon> In any case, your change LGTM, since it will still cause a fail if we do
> Simon> have debug info but see the bad output.
> 
> Thanks, I'm going to check it in.
> 
> Tom

Woops, I hit a FAIL here.  I think the $has_runtime_debug_info condition
is backwards

Simon

  reply	other threads:[~2023-01-27  5:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 16:31 Tom Tromey
2023-01-20 17:00 ` Simon Marchi
2023-01-20 17:05   ` Tom Tromey
2023-01-27  5:58     ` Simon Marchi [this message]
2023-01-27 14:11       ` Tom Tromey
2023-01-27 15:56         ` Simon Marchi
2023-01-27 17:24           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbb0f6ba-f164-af53-eaf0-b09255f0308a@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).