From: Simon Marchi <simark@simark.ca>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/5] regcache: Add collect/supply_regset variants that accept a register base.
Date: Tue, 22 Nov 2022 15:18:20 -0500 [thread overview]
Message-ID: <e441d76c-b447-629f-07e6-54d037a819d5@simark.ca> (raw)
In-Reply-To: <eebe3a5c-9675-fa8f-17a2-559d61e83ed1@simark.ca>
>> diff --git a/gdb/regcache.h b/gdb/regcache.h
>> index 1dbba5ce9af..f01127b20fb 100644
>> --- a/gdb/regcache.h
>> +++ b/gdb/regcache.h
>> @@ -150,6 +150,14 @@ extern void regcache_collect_regset (const struct regset *regset,
>> int regnum, void *buf, size_t size);
>>
>>
>> +extern void regcache_supply_regset (const struct regset *regset, int regbase,
>> + struct regcache *regcache,
>> + int regnum, const void *buf,
>> + size_t size);
>> +extern void regcache_collect_regset (const struct regset *regset, int regbase,
>> + const struct regcache *regcache,
>> + int regnum, void *buf, size_t size);
>
> These don't have a definition, I guess they are not needed.
>
> (Could we make a patch that removes regcache_supply_regset and
> regcache_collect_regset, since they just forward to the regcache
> methods?)
Answering my own question, no we can't. They are used as callbacks in
regset structures.
Simon
next prev parent reply other threads:[~2022-11-22 20:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 0:58 [PATCH 0/5] Improve support for regcache_map_entry with variable " John Baldwin
2022-07-08 0:58 ` [PATCH 1/5] regcache: Add collect/supply_regset variants that accept a " John Baldwin
2022-11-22 19:56 ` Simon Marchi
2022-11-22 20:18 ` Simon Marchi [this message]
2022-11-22 22:32 ` John Baldwin
2022-07-08 0:58 ` [PATCH 2/5] fbsd-nat: Use regset supply/collect methods John Baldwin
2022-11-22 20:20 ` Simon Marchi
2022-07-08 0:58 ` [PATCH 3/5] fbsd-nat: Pass an optional register base to the register set helpers John Baldwin
2022-11-22 20:38 ` Simon Marchi
2022-11-22 22:16 ` John Baldwin
2022-11-22 22:25 ` John Baldwin
2022-07-08 0:58 ` [PATCH 4/5] arm-fbsd: Use a static regset for the TLS register set John Baldwin
2022-11-22 20:39 ` Simon Marchi
2022-07-08 0:58 ` [PATCH 5/5] aarch64-fbsd: " John Baldwin
2022-11-22 20:40 ` Simon Marchi
2022-07-21 14:53 ` [PATCH 0/5] Improve support for regcache_map_entry with variable register base John Baldwin
2022-08-22 18:11 ` [PING] " John Baldwin
2022-09-20 17:50 ` John Baldwin
2022-10-20 20:26 ` [PING 4] " John Baldwin
2022-11-21 18:21 ` [PING 5] " John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e441d76c-b447-629f-07e6-54d037a819d5@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).