From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/3] [gdb] Eliminate local var pspace in inferior.c
Date: Thu, 9 Nov 2023 11:31:13 -0500 [thread overview]
Message-ID: <ed677608-fcbd-4fec-9794-73245e644bcf@simark.ca> (raw)
In-Reply-To: <20231109150021.5504-3-tdevries@suse.de>
On 11/9/23 10:00, Tom de Vries wrote:
> Eliminate local var pspace from functions add_inferior_with_spaces and
> clone_inferior_command.
>
> This interchanges the order of the new program space / new inferior events.
>
> Update test-case gdb.python/py-progspace-events.exp to reflect that.
>
> Tested on top of trunk on x86_64-linux and ppc64le-linux.
> Tested on top of gdb-14-branch on ppc64-linux.
>
> Suggested-By: Simon Marchi <simon.marchi@polymtl.ca>
Sorry, when I suggested this cleanup, I wasn't aware it would have
user-visible changes. Since there isn't a need for this except "make
the code a little nicer", I retract my suggestion.
Simon
next prev parent reply other threads:[~2023-11-09 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 15:00 [PATCH v3 0/3] [gdb] Fix segfault in for_each_block Tom de Vries
2023-11-09 15:00 ` [PATCH v3 1/3] [gdb] Fix segfault in for_each_block, part 1 Tom de Vries
2023-11-09 18:19 ` Simon Marchi
2023-11-10 8:14 ` Tom de Vries
2023-11-09 15:00 ` [PATCH v3 2/3] [gdb] Eliminate local var pspace in inferior.c Tom de Vries
2023-11-09 16:31 ` Simon Marchi [this message]
2023-11-10 8:15 ` Tom de Vries
2023-11-09 15:00 ` [PATCH v3 3/3] [gdb] Fix segfault in for_each_block, part 2 Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed677608-fcbd-4fec-9794-73245e644bcf@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).