Re: [PATCH v2] gdb/testsuite/README: point to default value of INTERNAL_GDBFLAGS

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2022-02-22 09:01, Philippe Blain wrote:
> Hi Simon,
> 
> Le 2022-02-22 à 08:46, Simon Marchi a écrit :
>> On 2022-02-20 11:49, Philippe Blain via Gdb-patches wrote:
>>> The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013
>>> ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to
>>> disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07)
>>> to point to the data directory, but its default value mentioned in the
>>> testsuite's README was not kept up to date.
>>>
>>> To avoid it getting out of sync even more, point the reader to the
>>> definition of the variable in lib/gdb.exp, and move the explanation of
>>> the different flags there. Also adjust the example in the README
>>> so it follows the flags added in 55c3ad88013.
>>
>> Thanks, this is ok.
>>
>> If you plan on contributing more patches, it would be useful for you to
>> get push access so you can push patches once they are approved.  Would
>> you prefer that?
> 
> I think I would be more comfortable if someone else pushes, at least for
> now, if you don't mind. I'm not completely clear on all the mechanics of the
> contribution flow for this project. If it becomes too much burden than I could 
> get push access. How does that sound ?

No problem, you just need to make it clear when someone approves your
patch that you need them to push the patch, otherwise it will fall
through the cracks.

I will push this one now.

> By the way, I did not yet sign the FSF copyright assigment. I don't know if
> this kind of patch would be OK without it, but anyway I'm happy to sign if needed.

Good point.  This patch is small enough, especially since you mostly
move existing text.  But if you plan on sending slightly more
significative patches, it would be good to have the copyright assignment
on file.  And it can take a bit of time, so better get the process
started early.

Simon