Re: [PATCH] gdb/testsuite/README: update default value of INTERNAL_GDBFLAGS

[Philippe Blain <levraiphilippeblain@gmail.com>]

Hi Simon,

> Le 19 févr. 2022 à 20:41, Simon Marchi <simon.marchi@polymtl.ca> a écrit :
> 
>> On 2022-02-19 18:40, Philippe Blain via Gdb-patches wrote:
>> The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013
>> ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to
>> disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07)
>> to point to the data directory, but its default value mentioned in the
>> testsuite's README was not kept up to date.
>> 
>> Update the README accordingly, and mention where the default value is
>> set, so that it's easier for futur new contributors to check if the
>> default mentioned in the README is still current.
>> ---
>> 
>> Notes:
>>    I noticed that while testing the fix for PR 24069, since I wanted
>>    to use my '~/.gdbinit' with 'set startup-with-shell off' for all tests,
>>    and found out that setting INTERNAL_GDBFLAGS to only '-nw' made some things
>>    a little worse (as GDB was then missing '-data-directory').
>> 
>>    Meta note: when I sent this patch earlier (and messed-up my CCs) in [1], I was
>>    confused by the fact that my CCs for Simon, Doug Evans and Tom de Vries were
>>    not showing up on public-inbox, even in the "raw" view [2]. After a little
>>    web search I think this is due to them setting the mailman "avoid duplicates"
>>    setting [3].
>> 
>>    [1] https://pi.simark.ca/gdb-patches/20220219212442.18136-1-levraiphilippeblain@gmail.com/T/#u
>>    [2] https://pi.simark.ca/gdb-patches/20220219212442.18136-1-levraiphilippeblain@gmail.com/raw
>>    [3] https://wiki.list.org/DOC/Mailman%202.1%20Members%20Manual#A7.2_How_can_I_avoid_getting_duplicate_messages.3F_.28duplicates_option.29
>> 
>> gdb/testsuite/README | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>> 
>> diff --git a/gdb/testsuite/README b/gdb/testsuite/README
>> index 7552774c78b..2d3f1c45966 100644
>> --- a/gdb/testsuite/README
>> +++ b/gdb/testsuite/README
>> @@ -168,11 +168,14 @@ INTERNAL_GDBFLAGS
>> 
>> Command line options passed to all GDB invocations.
>> 
>> -The default is "-nw -nx".
>> +The default is set in lib/gdb.exp and is currently
>> +"-nw -nx -data-directory /path/to/build/directory/gdb/data-directory -iex 'set height 0' -iex 'set width 0'".
>> 
>> `-nw' disables any of the windowed interfaces.
>> `-nx' disables ~/.gdbinit, so that it doesn't interfere with
>> the tests.
>> +`-data-directory` points the the data directory in the build directory
>> +`-iex 'set {height,width} 0'` disables pagination
> 
> I think this should just say "see the default in lib/gdb.exp", and the
> flags can be explained there.  That would avoid things getting out of
> sync.

Yes, you are probably right. I can send an updated patch with that change. 

Philippe.