From: Simon Marchi <simon.marchi@polymtl.ca>
To: Philippe Blain <levraiphilippeblain@gmail.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/testsuite/README: point to default value of INTERNAL_GDBFLAGS
Date: Tue, 22 Feb 2022 08:46:52 -0500 [thread overview]
Message-ID: <56b3a9a2-7807-62cf-c1a5-604ddb5864d8@polymtl.ca> (raw)
In-Reply-To: <20220220164912.87471-1-levraiphilippeblain@gmail.com>
On 2022-02-20 11:49, Philippe Blain via Gdb-patches wrote:
> The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013
> ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to
> disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07)
> to point to the data directory, but its default value mentioned in the
> testsuite's README was not kept up to date.
>
> To avoid it getting out of sync even more, point the reader to the
> definition of the variable in lib/gdb.exp, and move the explanation of
> the different flags there. Also adjust the example in the README
> so it follows the flags added in 55c3ad88013.
Thanks, this is ok.
If you plan on contributing more patches, it would be useful for you to
get push access so you can push patches once they are approved. Would
you prefer that?
Simon
next prev parent reply other threads:[~2022-02-22 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 23:40 [PATCH] gdb/testsuite/README: update " Philippe Blain
2022-02-20 1:41 ` Simon Marchi
2022-02-20 4:09 ` Philippe Blain
2022-02-20 16:49 ` [PATCH v2] gdb/testsuite/README: point to " Philippe Blain
2022-02-22 13:46 ` Simon Marchi [this message]
2022-02-22 14:01 ` Philippe Blain
2022-02-22 14:31 ` Simon Marchi
2022-02-22 14:45 ` Philippe Blain
2022-02-22 14:46 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b3a9a2-7807-62cf-c1a5-604ddb5864d8@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).