From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix various procfs.c compilation errors
Date: Thu, 17 Nov 2022 10:46:54 +0100 [thread overview]
Message-ID: <ydd4jux9alt.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <b3b28eef-6f1f-b81a-055a-e6c3b54a8af3@simark.ca> (Simon Marchi's message of "Wed, 16 Nov 2022 10:53:49 -0500")
Hi Simon,
> On 11/16/22 10:02, Rainer Orth wrote:
>> procfs.c has accumulated several compilation errors lately (some of them
>> new with GCC 12), which are fixed by this patch:
>>
>> * auxv_parse gets:
>>
>> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:144:7: error: ‘int
>> procfs_target::auxv_parse(gdb_byte**, gdb_byte*, CORE_ADDR*, CORE_ADDR*)’
>> marked ‘override’, but does not override
>> 144 | int auxv_parse (gdb_byte **readptr,
>> | ^~~~~~~~~~
>>
>> Obviouly, procfs.c was missed in the auxv_parse constification.
>
> Sorry, my bad for this one.
no worries while the fixes are as easy as this one. I thought about
reviving the old Solaris buildbots with the new buildmaster to catch
stuff like this early, but am uncertain: the old buildbods had been
compile-only for various reasons, but ISTM that the new ones need to be
compile-and-test, and zero-FAIL actually, which is completely
unattainable for Solaris right now.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2022-11-17 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 15:02 Rainer Orth
2022-11-16 15:53 ` Simon Marchi
2022-11-17 9:46 ` Rainer Orth [this message]
2022-11-16 17:30 ` Tom Tromey
2022-11-17 9:48 ` Rainer Orth
2022-11-16 19:04 ` Luis Machado
2022-11-17 9:50 ` Rainer Orth
2022-11-17 10:08 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ydd4jux9alt.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).