Re: [PATCH] Fix various procfs.c compilation errors

[Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>]

Hi Luis,

>> * find_memory_regions_callback fails with
>> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In function ‘int
>> find_memory_regions_callback(prmap*, find_memory_region_ftype, void*)’:
>> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3167:18: error: too few arguments to function
>>   3167 |   return (*func) ((CORE_ADDR) map->pr_vaddr,
>>        |          ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>   3168 |                   map->pr_size,
>>        |                   ~~~~~~~~~~~~~
>>   3169 |                   (map->pr_mflags & MA_READ) != 0,
>>        |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>   3170 |                   (map->pr_mflags & MA_WRITE) != 0,
>>        |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>   3171 |                   (map->pr_mflags & MA_EXEC) != 0,
>>        |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>   3172 |                   1, /* MODIFIED is unknown, pass it as true.  */
>>        |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>   3173 |                   data);
>>        |                   ~~~~~
>>    Again, procfs.c was overlooked when adding the new memory_tagged arg.
>>    Unfortunately, it wasn't even documented in gdb/defs.h when it was
>>    added in
>> 
>
> Sorry, that was an oversight. I failed to updated all the hooks. I think
> there was a BSD one that got fixed after the following commit was pushed.

no problem: the primary issue was finding/understanding what the new arg
meant/needs to be here.

Could you take care of updating the defs.h comment to avoid such
confusion in the future?

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University