public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple
@ 2011-04-07 5:15 jan.kratochvil at redhat dot com
2011-04-07 8:09 ` [Bug testsuite/12647] " jan.kratochvil at redhat dot com
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: jan.kratochvil at redhat dot com @ 2011-04-07 5:15 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=12647
Summary: racy: gdb.mi/ must not use gdb_test_multiple
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: testsuite
AssignedTo: unassigned@sourceware.org
ReportedBy: jan.kratochvil@redhat.com
gdb_test_multiple contains
-re "\r\n$gdb_prompt $" {
if ![string match "" $message] then {
fail "$message"
but this may falsely match an unfinished output expected to be matched by:
gdb_test_multiple "-environment-path" "-environment-path" {
-re "\\\^done,path=\"\(.*\)\"\r\n$mi_gdb_prompt" {
as mi_gdb_prompt is (without the angle brackets, ^M as \r\n delimiter):
<[(]gdb[)] ^M
>
while gdb_prompt is (without the angle brackets):
<\(gdb\)>
Unfortunately there ar 23 uses of gdb_test_multiple in gdb.mi/*.exp.
PASS: gdb.mi/mi2-basics.exp: environment-pwd operation
-environment-path^M
^done,path="/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin"^M
-(gdb) ^M
+(gdb) FAIL: gdb.mi/mi2-basics.exp: -environment-path
Expecting: ^(207-environment-path[^M
]+)?(207\^done,path="/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin"[^M
]+[(]gdb[)] ^M
[ ]*)
+^M
207-environment-path^M
207^done,path="/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin"^M
(gdb) ^M
-PASS: gdb.mi/mi2-basics.exp: environment-path no-args operation
+FAIL: gdb.mi/mi2-basics.exp: environment-path no-args operation
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple 2011-04-07 5:15 [Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple jan.kratochvil at redhat dot com @ 2011-04-07 8:09 ` jan.kratochvil at redhat dot com 2011-04-07 8:16 ` jan.kratochvil at redhat dot com ` (4 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: jan.kratochvil at redhat dot com @ 2011-04-07 8:09 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=12647 Jan Kratochvil <jan.kratochvil at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12649 -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple 2011-04-07 5:15 [Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple jan.kratochvil at redhat dot com 2011-04-07 8:09 ` [Bug testsuite/12647] " jan.kratochvil at redhat dot com @ 2011-04-07 8:16 ` jan.kratochvil at redhat dot com 2011-04-07 10:31 ` pedro at codesourcery dot com ` (3 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: jan.kratochvil at redhat dot com @ 2011-04-07 8:16 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=12647 Jan Kratochvil <jan.kratochvil at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #1 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2011-04-07 08:16:10 UTC --- This is only a special case of the general PR testsuite/12649. *** This bug has been marked as a duplicate of bug 12649 *** -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple 2011-04-07 5:15 [Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple jan.kratochvil at redhat dot com 2011-04-07 8:09 ` [Bug testsuite/12647] " jan.kratochvil at redhat dot com 2011-04-07 8:16 ` jan.kratochvil at redhat dot com @ 2011-04-07 10:31 ` pedro at codesourcery dot com 2011-04-07 10:32 ` pedro at codesourcery dot com ` (2 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: pedro at codesourcery dot com @ 2011-04-07 10:31 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=12647 Pedro Alves <pedro at codesourcery dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro at codesourcery dot | |com --- Comment #2 from Pedro Alves <pedro at codesourcery dot com> 2011-04-07 10:31:07 UTC --- Plus, gdb_test_multiple is tied to CLI's output internally. The fact that it works most of the time appears only to be a fortunate accident. Should we have an mi_gdb_test_multiple instead? Either that, or I think we should consider reverting all gdb_test_multiple uses under gdb.mi/ back to send_gdb/gdb_test. They were added not that long ago. The original patch: <http://sourceware.org/ml/gdb-patches/2010-05/msg00586.html> -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple 2011-04-07 5:15 [Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple jan.kratochvil at redhat dot com ` (2 preceding siblings ...) 2011-04-07 10:31 ` pedro at codesourcery dot com @ 2011-04-07 10:32 ` pedro at codesourcery dot com 2011-05-05 18:19 ` mpolacek at redhat dot com 2024-01-14 15:04 ` vries at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: pedro at codesourcery dot com @ 2011-04-07 10:32 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=12647 Pedro Alves <pedro at codesourcery dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE | --- Comment #3 from Pedro Alves <pedro at codesourcery dot com> 2011-04-07 10:32:03 UTC --- I think using gdb_test_multiple in MI test hides more than testsuite/12649. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple 2011-04-07 5:15 [Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple jan.kratochvil at redhat dot com ` (3 preceding siblings ...) 2011-04-07 10:32 ` pedro at codesourcery dot com @ 2011-05-05 18:19 ` mpolacek at redhat dot com 2024-01-14 15:04 ` vries at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: mpolacek at redhat dot com @ 2011-05-05 18:19 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=12647 Marek Polacek <mpolacek at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mpolacek at redhat dot com -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple 2011-04-07 5:15 [Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple jan.kratochvil at redhat dot com ` (4 preceding siblings ...) 2011-05-05 18:19 ` mpolacek at redhat dot com @ 2024-01-14 15:04 ` vries at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: vries at gcc dot gnu.org @ 2024-01-14 15:04 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=12647 Bug 12647 depends on bug 12649, which changed state. Bug 12649 Summary: reproducer for races of expect incomplete reads https://sourceware.org/bugzilla/show_bug.cgi?id=12649 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-14 15:04 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2011-04-07 5:15 [Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple jan.kratochvil at redhat dot com 2011-04-07 8:09 ` [Bug testsuite/12647] " jan.kratochvil at redhat dot com 2011-04-07 8:16 ` jan.kratochvil at redhat dot com 2011-04-07 10:31 ` pedro at codesourcery dot com 2011-04-07 10:32 ` pedro at codesourcery dot com 2011-05-05 18:19 ` mpolacek at redhat dot com 2024-01-14 15:04 ` vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).