[Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple

[Bug testsuite/12647] New: racy: gdb.mi/ must not use gdb_test_multiple

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12647

           Summary: racy: gdb.mi/ must not use gdb_test_multiple
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
        AssignedTo: unassigned@sourceware.org
        ReportedBy: jan.kratochvil@redhat.com


gdb_test_multiple contains
         -re "\r\n$gdb_prompt $" {
            if ![string match "" $message] then {
                fail "$message"

but this may falsely match an unfinished output expected to be matched by:
    gdb_test_multiple "-environment-path" "-environment-path" {
        -re "\\\^done,path=\"\(.*\)\"\r\n$mi_gdb_prompt" {

as mi_gdb_prompt is (without the angle brackets, ^M as \r\n delimiter):
<[(]gdb[)] ^M
>
while gdb_prompt is (without the angle brackets):
<\(gdb\)>

Unfortunately there ar 23 uses of gdb_test_multiple in gdb.mi/*.exp.

 PASS: gdb.mi/mi2-basics.exp: environment-pwd operation
 -environment-path^M
 ^done,path="/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin"^M
-(gdb) ^M
+(gdb) FAIL: gdb.mi/mi2-basics.exp: -environment-path
 Expecting: ^(207-environment-path[^M

]+)?(207\^done,path="/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin"[^M
 ]+[(]gdb[)] ^M
 [ ]*)
+^M
 207-environment-path^M
 207^done,path="/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin"^M
 (gdb) ^M
-PASS: gdb.mi/mi2-basics.exp: environment-path no-args operation
+FAIL: gdb.mi/mi2-basics.exp: environment-path no-args operation

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12647

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12649

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12647

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #1 from Jan Kratochvil <jan.kratochvil at redhat dot com> 2011-04-07 08:16:10 UTC ---
This is only a special case of the general PR testsuite/12649.

*** This bug has been marked as a duplicate of bug 12649 ***

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple

[pedro at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12647

Pedro Alves <pedro at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedro at codesourcery dot
                   |                            |com

--- Comment #2 from Pedro Alves <pedro at codesourcery dot com> 2011-04-07 10:31:07 UTC ---
Plus, gdb_test_multiple is tied to CLI's output internally.
The fact that it works most of the time appears only to be a fortunate
accident.  Should we have an mi_gdb_test_multiple instead?  Either
that, or I think we should consider reverting all gdb_test_multiple
uses under gdb.mi/ back to send_gdb/gdb_test.  They were added not
that long ago.  The original patch:

<http://sourceware.org/ml/gdb-patches/2010-05/msg00586.html>

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple

[pedro at codesourcery dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12647

Pedro Alves <pedro at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |

--- Comment #3 from Pedro Alves <pedro at codesourcery dot com> 2011-04-07 10:32:03 UTC ---
I think using gdb_test_multiple in MI test hides more than testsuite/12649.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple

[mpolacek at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12647

Marek Polacek <mpolacek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at redhat dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug testsuite/12647] racy: gdb.mi/ must not use gdb_test_multiple

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=12647
Bug 12647 depends on bug 12649, which changed state.

Bug 12649 Summary: reproducer for races of expect incomplete reads
https://sourceware.org/bugzilla/show_bug.cgi?id=12649

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.