[Bug gdb/15678] New: Typing "enable count" crashes gdb

[Bug gdb/15678] New: Typing "enable count" crashes gdb

[simon.marchi at ericsson dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15678

            Bug ID: 15678
           Summary: Typing "enable count" crashes gdb
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: simon.marchi at ericsson dot com

Step 1: Launch gdb
Step 2: Type "enable count"

Observed behaviour: gdb crashes
Expected behaviour: gdb tells me subtly that I should go back to school and
learn to read better.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/15678] Typing "enable count" crashes gdb

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15678

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.kratochvil at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/15678] Typing "enable count" crashes gdb

[jan.kratochvil at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15678

--- Comment #1 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
[PATCH] "enable count" user input error handling (PR gdb/15678)
http://sourceware.org/ml/gdb-patches/2013-06/msg00788.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/15678] Typing "enable count" crashes gdb

[palves at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15678

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |palves at redhat dot com
           Assignee|unassigned at sourceware dot org   |simon.marchi at ericsson dot com

--- Comment #2 from Pedro Alves <palves at redhat dot com> ---
Patch here:

  http://sourceware.org/ml/gdb-patches/2013-06/msg00788.html

Waiting for copyright assignment to come through.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/15678] Typing "enable count" crashes gdb

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15678

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b9d6130764916fac3d9bcfde2d672053a0ef3316

commit b9d6130764916fac3d9bcfde2d672053a0ef3316
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Mon Feb 2 14:57:31 2015 -0500

    "enable count" user input error handling (PR gdb/15678)

    Typing "enable count" by itself crashes GDB. Also, if you omit the
    breakpoint number/range, the error message is not very clear:

    (gdb) enable count 2
    warning: bad breakpoint number at or near ''
    (gdb) enable count
    Segmentation fault (core dumped)

    With this patch, the error messages are slightly more helpful:

    (gdb) enable count 2
    Argument required (one or more breakpoint numbers).
    (gdb) enable count
    Argument required (hit count).

    gdb/ChangeLog:

        PR gdb/15678
        * breakpoint.c (map_breakpoint_numbers): Check for empty args
        string.
        (enable_count_command): Check args for NULL value.

    gdb/testsuite/ChangeLog:

        PR gdb/15678
        * gdb.base/ena-dis-br.exp: Test "enable count" for bad user input.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/15678] Typing "enable count" crashes gdb

[simon.marchi at ericsson dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15678

Simon Marchi <simon.marchi at ericsson dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Simon Marchi <simon.marchi at ericsson dot com> ---
Fixed by patch above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.