[Bug cli/16122] New: Unify interactivity tests to use input_from_terminal_p

[Bug cli/16122] New: Unify interactivity tests to use input_from_terminal_p

[mbilal at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16122

            Bug ID: 16122
           Summary: Unify interactivity tests to use input_from_terminal_p
           Product: gdb
           Version: 7.6
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cli
          Assignee: unassigned at sourceware dot org
          Reporter: mbilal at codesourcery dot com

On Mon, 01 Apr 2013 16:15:11 +0200, Pedro Alves wrote on gdb-patches 
> We don't add commands to history unless we're interactive debugging:
> 
>   /* Add line to history if appropriate.  */
>   if (instream == stdin
>       && ISATTY (stdin) && *linebuffer)
>     add_history (linebuffer);
+
> Probably, it'd be best to use input_from_terminal_p, which also
> checks for --batch mode, among other things.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/16122] Unify interactivity tests to use input_from_terminal_p

[mbilal at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16122

hmb <mbilal at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15224

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/16122] Unify interactivity tests to use input_from_terminal_p

[mbilal at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16122

hmb <mbilal at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |mbilal at codesourcery dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/16122] Unify interactivity tests to use input_from_terminal_p

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=16122

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
       via  840da61ad95439a10bce40329bf82e033ec4711b (commit)
      from  6dbb67982ced8b06deb512c0a357767f5ed486df (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=840da61ad95439a10bce40329bf82e033ec4711b

commit 840da61ad95439a10bce40329bf82e033ec4711b
Author: Muhammad Bilal <mbilal@codesourcery.com>
Date:   Wed Nov 6 11:42:52 2013 +0500

    2013-11-06  Muhammad Bilal  <mbilal@codesourcery.com>

           PR cli/16122
           * top.c (command_line_input): Unify interactivity tests to use
           input_from_terminal_p.
           * event-top.c (command_line_handler): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 gdb/ChangeLog   |    7 +++++++
 gdb/event-top.c |    3 +--
 gdb/top.c       |    3 +--
 3 files changed, 9 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/16122] Unify interactivity tests to use input_from_terminal_p

[mbilal at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16122

hmb <mbilal at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from hmb <mbilal at codesourcery dot com> ---
fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/16122] Unify interactivity tests to use input_from_terminal_p

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16122

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15224
         Depends on|15224                       |

-- 
You are receiving this mail because:
You are on the CC list for the bug.