public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "tom_van at users dot sourceforge.net" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug remote/18024] New: non-stop mode notification from server sometimes not handled properly Date: Wed, 25 Feb 2015 13:26:00 -0000 [thread overview] Message-ID: <bug-18024-4717@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=18024 Bug ID: 18024 Summary: non-stop mode notification from server sometimes not handled properly Product: gdb Version: 7.9 Status: NEW Severity: normal Priority: P2 Component: remote Assignee: unassigned at sourceware dot org Reporter: tom_van at users dot sourceforge.net GNU gdb (GDB) 7.9.50.20150225-cvs This GDB was configured as "--host=i686-pc-linux-gnu --target=arm-none-eabi". In non-stop mode gdb sometimes shows an error on receive of notification %Stop:T05.... Inspection of remoce.c shows obvious problem in handle_notification call. At remote.c:7368 handle_notification() is correctly called with rs->buf pointing to the first char after '%'. At remote.c:7757 handle_notification() called with *buf pointing to a leading '%' and therefore packet not handled correctly. Proposed patch ----------------- --- a/gdb/remote.c +++ b/gdb/remote.c @@ -7751,7 +7751,7 @@ getpkt_or_notif_sane_1 (char **buf, long *sizeof_buf, int forever, if (is_notif != NULL) *is_notif = 1; - handle_notification (rs->notif_state, *buf); + handle_notification (rs->notif_state, (*buf) + 1); /* Notifications require no acknowledgement. */ -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2015-02-25 13:25 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-02-25 13:26 tom_van at users dot sourceforge.net [this message] 2015-02-25 15:54 ` [Bug remote/18024] " tom_van at users dot sourceforge.net 2022-12-21 18:05 ` tromey at sourceware dot org 2023-08-03 17:06 ` tromey at sourceware dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-18024-4717@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).