[Bug remote/18024] New: non-stop mode notification from server sometimes not handled properly

[Bug remote/18024] New: non-stop mode notification from server sometimes not handled properly

[tom_van at users dot sourceforge.net]

https://sourceware.org/bugzilla/show_bug.cgi?id=18024

            Bug ID: 18024
           Summary: non-stop mode notification from server sometimes not
                    handled properly
           Product: gdb
           Version: 7.9
            Status: NEW
          Severity: normal
          Priority: P2
         Component: remote
          Assignee: unassigned at sourceware dot org
          Reporter: tom_van at users dot sourceforge.net

GNU gdb (GDB) 7.9.50.20150225-cvs
This GDB was configured as "--host=i686-pc-linux-gnu --target=arm-none-eabi".

In non-stop mode gdb sometimes shows an error on receive of notification
%Stop:T05....

Inspection of remoce.c shows obvious problem in handle_notification call.
At remote.c:7368 handle_notification() is correctly called with rs->buf
pointing to the first char after '%'.
At remote.c:7757 handle_notification() called with *buf pointing to a leading
'%' and therefore packet not handled correctly.

Proposed patch
-----------------
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -7751,7 +7751,7 @@ getpkt_or_notif_sane_1 (char **buf, long *sizeof_buf, int
forever,
          if (is_notif != NULL)
            *is_notif = 1;

-         handle_notification (rs->notif_state, *buf);
+         handle_notification (rs->notif_state, (*buf) + 1);

          /* Notifications require no acknowledgement.  */

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/18024] non-stop mode notification from server sometimes not handled properly

[tom_van at users dot sourceforge.net]

https://sourceware.org/bugzilla/show_bug.cgi?id=18024

Tomas Vanek <tom_van at users dot sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tom_van at users dot sourceforge.n
                   |                            |et

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/18024] non-stop mode notification from server sometimes not handled properly

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18024

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Offhand it seems reasonable but I wonder how to test/reproduce the problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug remote/18024] non-stop mode notification from server sometimes not handled properly

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18024

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I can't see how this would happen with the current code.
It looks like read_frame is called to fill 'buf'
after the '%' is read.
I wonder if this can be reproduced?

-- 
You are receiving this mail because:
You are on the CC list for the bug.