public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug remote/18024] New: non-stop mode notification from server sometimes not handled properly @ 2015-02-25 13:26 tom_van at users dot sourceforge.net 2015-02-25 15:54 ` [Bug remote/18024] " tom_van at users dot sourceforge.net ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: tom_van at users dot sourceforge.net @ 2015-02-25 13:26 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=18024 Bug ID: 18024 Summary: non-stop mode notification from server sometimes not handled properly Product: gdb Version: 7.9 Status: NEW Severity: normal Priority: P2 Component: remote Assignee: unassigned at sourceware dot org Reporter: tom_van at users dot sourceforge.net GNU gdb (GDB) 7.9.50.20150225-cvs This GDB was configured as "--host=i686-pc-linux-gnu --target=arm-none-eabi". In non-stop mode gdb sometimes shows an error on receive of notification %Stop:T05.... Inspection of remoce.c shows obvious problem in handle_notification call. At remote.c:7368 handle_notification() is correctly called with rs->buf pointing to the first char after '%'. At remote.c:7757 handle_notification() called with *buf pointing to a leading '%' and therefore packet not handled correctly. Proposed patch ----------------- --- a/gdb/remote.c +++ b/gdb/remote.c @@ -7751,7 +7751,7 @@ getpkt_or_notif_sane_1 (char **buf, long *sizeof_buf, int forever, if (is_notif != NULL) *is_notif = 1; - handle_notification (rs->notif_state, *buf); + handle_notification (rs->notif_state, (*buf) + 1); /* Notifications require no acknowledgement. */ -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug remote/18024] non-stop mode notification from server sometimes not handled properly 2015-02-25 13:26 [Bug remote/18024] New: non-stop mode notification from server sometimes not handled properly tom_van at users dot sourceforge.net @ 2015-02-25 15:54 ` tom_van at users dot sourceforge.net 2022-12-21 18:05 ` tromey at sourceware dot org 2023-08-03 17:06 ` tromey at sourceware dot org 2 siblings, 0 replies; 4+ messages in thread From: tom_van at users dot sourceforge.net @ 2015-02-25 15:54 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=18024 Tomas Vanek <tom_van at users dot sourceforge.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tom_van at users dot sourceforge.n | |et -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug remote/18024] non-stop mode notification from server sometimes not handled properly 2015-02-25 13:26 [Bug remote/18024] New: non-stop mode notification from server sometimes not handled properly tom_van at users dot sourceforge.net 2015-02-25 15:54 ` [Bug remote/18024] " tom_van at users dot sourceforge.net @ 2022-12-21 18:05 ` tromey at sourceware dot org 2023-08-03 17:06 ` tromey at sourceware dot org 2 siblings, 0 replies; 4+ messages in thread From: tromey at sourceware dot org @ 2022-12-21 18:05 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=18024 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tromey at sourceware dot org --- Comment #1 from Tom Tromey <tromey at sourceware dot org> --- Offhand it seems reasonable but I wonder how to test/reproduce the problem. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug remote/18024] non-stop mode notification from server sometimes not handled properly 2015-02-25 13:26 [Bug remote/18024] New: non-stop mode notification from server sometimes not handled properly tom_van at users dot sourceforge.net 2015-02-25 15:54 ` [Bug remote/18024] " tom_van at users dot sourceforge.net 2022-12-21 18:05 ` tromey at sourceware dot org @ 2023-08-03 17:06 ` tromey at sourceware dot org 2 siblings, 0 replies; 4+ messages in thread From: tromey at sourceware dot org @ 2023-08-03 17:06 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=18024 Tom Tromey <tromey at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |WAITING --- Comment #2 from Tom Tromey <tromey at sourceware dot org> --- I can't see how this would happen with the current code. It looks like read_frame is called to fill 'buf' after the '%' is read. I wonder if this can be reproduced? -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-03 17:06 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-02-25 13:26 [Bug remote/18024] New: non-stop mode notification from server sometimes not handled properly tom_van at users dot sourceforge.net 2015-02-25 15:54 ` [Bug remote/18024] " tom_van at users dot sourceforge.net 2022-12-21 18:05 ` tromey at sourceware dot org 2023-08-03 17:06 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).