[Bug build/18632] New: Don't build readline/libreadline.a, when --with-system-readline is supplied

[Bug build/18632] New: Don't build readline/libreadline.a, when --with-system-readline is supplied

[dilyan.palauzov at aegee dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

            Bug ID: 18632
           Summary: Don't build readline/libreadline.a, when
                    --with-system-readline is supplied
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: dilyan.palauzov at aegee dot org
  Target Milestone: ---

The bundled libreadline is always built, even if the system is ./configure'd
--with-system-readline and the build libreadline.a is not used.

Proposed patch:

Fix ./configure.ac not to proceed readline/, when --with-system-readline is
provided

diff --git a/configure.ac b/configure.ac
index 159f968..adf6dfb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi

+# Don't compile the bundled readline/libreadline.a if --with-system-readline
+# is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 # some tools are so dependent upon X11 that if we're not building with X, 
 # it's not even worth trying to configure, much less build, that tool.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18632] Don't build readline/libreadline.a, when --with-system-readline is supplied

[pinskia at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #7)
> I believe this fix was checked in.

Yes
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;f=configure.ac;h=69961a84c9b3744a10248fb6cbccc3c688a1e0a5

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18632] Don't build readline/libreadline.a, when --with-system-readline is supplied

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |vries at gcc dot gnu.org
         Resolution|FIXED                       |---

--- Comment #9 from Tom de Vries <vries at gcc dot gnu.org> ---
Unfixed by commit 228cf97dd3c ("Merge configure.ac from gcc project").

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18632] Don't build readline/libreadline.a, when --with-system-readline is supplied

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

--- Comment #10 from Tom de Vries <vries at gcc dot gnu.org> ---
Reapplied in gdb.  Now let's not close this one before we've propagated to gcc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/18632] Don't build readline/libreadline.a, when --with-system-readline is supplied

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #10)
> Reapplied in gdb.  Now let's not close this one before we've propagated to
> gcc.

Done:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=36ba985145ffa8e2078033fc1f1cf22851707a8e

Marking fixed again.  Keeping milestone 8.3 because releases are not affected.

-- 
You are receiving this mail because:
You are on the CC list for the bug.