public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID
@ 2015-09-15 16:10 palves at redhat dot com
2015-09-15 16:10 ` [Bug remote/18965] " palves at redhat dot com
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: palves at redhat dot com @ 2015-09-15 16:10 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
Bug ID: 18965
Summary: new vforkdone stop reply should indicate parent
process ID
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: remote
Assignee: unassigned at sourceware dot org
Reporter: palves at redhat dot com
Target Milestone: ---
The new vforkdone stop reply misses indicating the thread ID of the vfork
parent which the event relates to:
Note:
@cindex vforkdone events, remote reply
@item vforkdone
The packet indicates that a child process created by a vfork
has either called @code{exec} or terminated, so that the
address spaces of the parent and child process are no longer
shared. The @var{r} part is ignored. This packet is only
applicable to targets that support vforkdone events.
vs:
@cindex vfork events, remote reply
@item vfork
The packet indicates that @code{vfork} was called, and @var{r}
is the thread ID of the new child process. Refer to
@ref{thread-id syntax} for the format of the @var{thread-id}
field. This packet is only applicable to targets that support
vfork events.
Unfortunately, this is not just a documentation issue. GDBserver
is really not specifying the thread ID. In non-stop mode, gdb complains:
[Thread 6089.6089] #1 stopped.
#0 0x0000003615a011f0 in ?? ()
0x0000003615a011f0 in ?? ()
(gdb) set debug remote 1
(gdb) c
Continuing.
Sending packet: $QPassSignals:e;10;14;17;1a;1b;1c;21;24;25;2c;4c;#5f...Packet
received: OK
Sending packet: $vCont;c:p17c9.17c9#88...Packet received: OK
Notification received:
Stop:T05vfork:p17ce.17ce;06:40d7ffffff7f0000;07:30d7ffffff7f0000;10:e4c9eb1536000000;thread:p17c9.17c9;core:2;
Sending packet: $vStopped#55...Packet received: OK
Sending packet: $D;17ce#af...Packet received: OK
Sending packet: $vCont;c:p17c9.17c9#88...Packet received: OK
Notification received: Stop:T05vforkdone:;
No process or thread specified in stop reply: T05vforkdone:;
(gdb)
This is not non-stop-mode-specific, however. Consider e.g., that
in all-stop, you may be debugging more than one process at the
same time. You continue, and both processes vfork. So if you next
a T05vforkdone, there's no way to tell which of the parent processes
is done with the vfork.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/18965] new vforkdone stop reply should indicate parent process ID
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
@ 2015-09-15 16:10 ` palves at redhat dot com
2015-09-15 16:33 ` cvs-commit at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: palves at redhat dot com @ 2015-09-15 16:10 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
Pedro Alves <palves at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|HEAD |7.10
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/18965] new vforkdone stop reply should indicate parent process ID
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
2015-09-15 16:10 ` [Bug remote/18965] " palves at redhat dot com
@ 2015-09-15 16:33 ` cvs-commit at gcc dot gnu.org
2015-09-15 16:37 ` cvs-commit at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-15 16:33 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8228463cbca8d629572dbad99286c4e05886350b
commit 8228463cbca8d629572dbad99286c4e05886350b
Author: Pedro Alves <palves@redhat.com>
Date: Tue Sep 15 17:32:45 2015 +0100
PR remote/18965: vforkdone stop reply should indicate parent PID
The vforkdone stop reply misses indicating the thread ID of the vfork
parent which the event relates to:
@cindex vfork events, remote reply
@item vfork
The packet indicates that @code{vfork} was called, and @var{r}
is the thread ID of the new child process. Refer to
@ref{thread-id syntax} for the format of the @var{thread-id}
field. This packet is only applicable to targets that support
vfork events.
@cindex vforkdone events, remote reply
@item vforkdone
The packet indicates that a child process created by a vfork
has either called @code{exec} or terminated, so that the
address spaces of the parent and child process are no longer
shared. The @var{r} part is ignored. This packet is only
applicable to targets that support vforkdone events.
Unfortunately, this is not just a documentation issue. GDBserver
is really not specifying the thread ID. I noticed because
in non-stop mode, gdb complains:
[Thread 6089.6089] #1 stopped.
#0 0x0000003615a011f0 in ?? ()
0x0000003615a011f0 in ?? ()
(gdb) set debug remote 1
(gdb) c
Continuing.
Sending packet:
$QPassSignals:e;10;14;17;1a;1b;1c;21;24;25;2c;4c;#5f...Packet received: OK
Sending packet: $vCont;c:p17c9.17c9#88...Packet received: OK
Notification received:
Stop:T05vfork:p17ce.17ce;06:40d7ffffff7f0000;07:30d7ffffff7f0000;10:e4c9eb1536000000;thread:p17c9.17c9;core:2;
Sending packet: $vStopped#55...Packet received: OK
Sending packet: $D;17ce#af...Packet received: OK
Sending packet: $vCont;c:p17c9.17c9#88...Packet received: OK
Notification received: Stop:T05vforkdone:;
No process or thread specified in stop reply: T05vforkdone:;
(gdb)
This is not non-stop-mode-specific, however. Consider e.g., that in
all-stop, you may be debugging more than one process at the same time.
You continue, and both processes vfork. So when you next get a
T05vforkdone, there's no way to tell which of the parent processes is
done with the vfork.
Tests will be added later.
Tested on x86_64 Fedora 20.
gdb/ChangeLog:
2015-09-15 Pedro Alves <palves@redhat.com>
PR remote/18965
* remote-utils.c (prepare_resume_reply): Merge
TARGET_WAITKIND_VFORK_DONE switch case with the
TARGET_WAITKIND_FORKED case.
gdb/doc/ChangeLog:
2015-09-15 Pedro Alves <palves@redhat.com>
PR remote/18965
* gdb.texinfo (Stop Reply Packets): Explain that vforkdone's 'r'
part indicates the thread ID of the parent process.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/18965] new vforkdone stop reply should indicate parent process ID
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
2015-09-15 16:10 ` [Bug remote/18965] " palves at redhat dot com
2015-09-15 16:33 ` cvs-commit at gcc dot gnu.org
@ 2015-09-15 16:37 ` cvs-commit at gcc dot gnu.org
2015-09-15 17:03 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-15 16:37 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5a676acc4bba751c7746c4a200a054d6c557f3ee
commit 5a676acc4bba751c7746c4a200a054d6c557f3ee
Author: Pedro Alves <palves@redhat.com>
Date: Tue Sep 15 17:35:21 2015 +0100
Move ChangeLog entry to proper place
gdb/ChangeLog -> gdb/gdbserver/ChangeLog
2015-09-15 Pedro Alves <palves@redhat.com>
PR remote/18965
* remote-utils.c (prepare_resume_reply): Merge
TARGET_WAITKIND_VFORK_DONE switch case with the
TARGET_WAITKIND_FORKED case.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/18965] new vforkdone stop reply should indicate parent process ID
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
` (2 preceding siblings ...)
2015-09-15 16:37 ` cvs-commit at gcc dot gnu.org
@ 2015-09-15 17:03 ` cvs-commit at gcc dot gnu.org
2015-09-15 17:06 ` palves at redhat dot com
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-15 17:03 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-7.10-branch branch has been updated by Pedro Alves
<palves@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=487bf2f7066948fffd3447a3c6dd83389a037e2d
commit 487bf2f7066948fffd3447a3c6dd83389a037e2d
Author: Pedro Alves <palves@redhat.com>
Date: Tue Sep 15 17:45:26 2015 +0100
PR remote/18965: vforkdone stop reply should indicate parent PID
The vforkdone stop reply misses indicating the thread ID of the vfork
parent which the event relates to:
@cindex vfork events, remote reply
@item vfork
The packet indicates that @code{vfork} was called, and @var{r}
is the thread ID of the new child process. Refer to
@ref{thread-id syntax} for the format of the @var{thread-id}
field. This packet is only applicable to targets that support
vfork events.
@cindex vforkdone events, remote reply
@item vforkdone
The packet indicates that a child process created by a vfork
has either called @code{exec} or terminated, so that the
address spaces of the parent and child process are no longer
shared. The @var{r} part is ignored. This packet is only
applicable to targets that support vforkdone events.
Unfortunately, this is not just a documentation issue. GDBserver
is really not specifying the thread ID. I noticed because
in non-stop mode, gdb complains:
[Thread 6089.6089] #1 stopped.
#0 0x0000003615a011f0 in ?? ()
0x0000003615a011f0 in ?? ()
(gdb) set debug remote 1
(gdb) c
Continuing.
Sending packet:
$QPassSignals:e;10;14;17;1a;1b;1c;21;24;25;2c;4c;#5f...Packet received: OK
Sending packet: $vCont;c:p17c9.17c9#88...Packet received: OK
Notification received:
Stop:T05vfork:p17ce.17ce;06:40d7ffffff7f0000;07:30d7ffffff7f0000;10:e4c9eb1536000000;thread:p17c9.17c9;core:2;
Sending packet: $vStopped#55...Packet received: OK
Sending packet: $D;17ce#af...Packet received: OK
Sending packet: $vCont;c:p17c9.17c9#88...Packet received: OK
Notification received: Stop:T05vforkdone:;
No process or thread specified in stop reply: T05vforkdone:;
(gdb)
This is not non-stop-mode-specific, however. Consider e.g., that in
all-stop, you may be debugging more than one process at the same time.
You continue, and both processes vfork. So when you next get a
T05vforkdone, there's no way to tell which of the parent processes is
done with the vfork.
Tests will be added later.
Tested on x86_64 Fedora 20.
gdb/gdbserver/ChangeLog:
2015-09-15 Pedro Alves <palves@redhat.com>
PR remote/18965
* remote-utils.c (prepare_resume_reply): Merge
TARGET_WAITKIND_VFORK_DONE switch case with the
TARGET_WAITKIND_FORKED case.
gdb/doc/ChangeLog:
2015-09-15 Pedro Alves <palves@redhat.com>
PR remote/18965
* gdb.texinfo (Stop Reply Packets): Explain that vforkdone's 'r'
part indicates the thread ID of the parent process.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/18965] new vforkdone stop reply should indicate parent process ID
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
` (3 preceding siblings ...)
2015-09-15 17:03 ` cvs-commit at gcc dot gnu.org
@ 2015-09-15 17:06 ` palves at redhat dot com
2015-09-15 18:34 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: palves at redhat dot com @ 2015-09-15 17:06 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
Pedro Alves <palves at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |7.10
--- Comment #4 from Pedro Alves <palves at redhat dot com> ---
Fixed in (the future) 7.10.1 and master.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/18965] new vforkdone stop reply should indicate parent process ID
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
` (4 preceding siblings ...)
2015-09-15 17:06 ` palves at redhat dot com
@ 2015-09-15 18:34 ` cvs-commit at gcc dot gnu.org
2015-09-15 18:37 ` cvs-commit at gcc dot gnu.org
2021-10-21 6:50 ` bap.fayol at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-15 18:34 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e68fa6f07666ec4726cfef59f641a81244cc2e00
commit e68fa6f07666ec4726cfef59f641a81244cc2e00
Author: Pedro Alves <palves@redhat.com>
Date: Tue Sep 15 19:29:37 2015 +0100
gdb/doc: revert previous vforkdone change
The previous manual change was wrong. The vfork parent thread ID
should be reported with the usual "thread" magic register:
Sending packet: $vCont;c:p7260.7260#1e...Packet received: OK
- Notification received: Stop:T05vforkdone:;
+ Notification received: Stop:T05vforkdone:;thread:p7260.7260
^^^^^^^^^^^^^^^^^
This is already how the parent is reported in the vfork/fork events,
and is actually what the fix made gdbserver do. Following the
documentation change, the event would have been reported like this
instead:
Notification received: Stop:T05vforkdone:p7260.7260
gdb/doc/ChangeLog:
2015-09-15 Pedro Alves <palves@redhat.com>
PR remote/18965
* gdb.texinfo (Stop Reply Packets): Revert previous change to
the vforkdone description.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/18965] new vforkdone stop reply should indicate parent process ID
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
` (5 preceding siblings ...)
2015-09-15 18:34 ` cvs-commit at gcc dot gnu.org
@ 2015-09-15 18:37 ` cvs-commit at gcc dot gnu.org
2021-10-21 6:50 ` bap.fayol at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2015-09-15 18:37 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-7.10-branch branch has been updated by Pedro Alves
<palves@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9c53c9a4a221addc05c0cd3a8f44974d8c8b2444
commit 9c53c9a4a221addc05c0cd3a8f44974d8c8b2444
Author: Pedro Alves <palves@redhat.com>
Date: Tue Sep 15 19:35:56 2015 +0100
gdb/doc: revert previous vforkdone change
The previous manual change was wrong. The vfork parent thread ID
should be reported with the usual "thread" magic register:
Sending packet: $vCont;c:p7260.7260#1e...Packet received: OK
- Notification received: Stop:T05vforkdone:;
+ Notification received: Stop:T05vforkdone:;thread:p7260.7260
^^^^^^^^^^^^^^^^^
This is already how the parent is reported in the vfork/fork events,
and is actually what the fix made gdbserver do. Following the
documentation change, the event would have been reported like this
instead:
Notification received: Stop:T05vforkdone:p7260.7260
gdb/doc/ChangeLog:
2015-09-15 Pedro Alves <palves@redhat.com>
PR remote/18965
* gdb.texinfo (Stop Reply Packets): Revert previous change to
the vforkdone description.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug remote/18965] new vforkdone stop reply should indicate parent process ID
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
` (6 preceding siblings ...)
2015-09-15 18:37 ` cvs-commit at gcc dot gnu.org
@ 2021-10-21 6:50 ` bap.fayol at gmail dot com
7 siblings, 0 replies; 9+ messages in thread
From: bap.fayol at gmail dot com @ 2021-10-21 6:50 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=18965
yaoltreza <bap.fayol at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bap.fayol at gmail dot com
--- Comment #7 from yaoltreza <bap.fayol at gmail dot com> ---
thank you for all the tips. https://www.eaukangen.net/
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-10-21 6:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-15 16:10 [Bug remote/18965] New: new vforkdone stop reply should indicate parent process ID palves at redhat dot com
2015-09-15 16:10 ` [Bug remote/18965] " palves at redhat dot com
2015-09-15 16:33 ` cvs-commit at gcc dot gnu.org
2015-09-15 16:37 ` cvs-commit at gcc dot gnu.org
2015-09-15 17:03 ` cvs-commit at gcc dot gnu.org
2015-09-15 17:06 ` palves at redhat dot com
2015-09-15 18:34 ` cvs-commit at gcc dot gnu.org
2015-09-15 18:37 ` cvs-commit at gcc dot gnu.org
2021-10-21 6:50 ` bap.fayol at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).