public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "blarsen at redhat dot com" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug record/24073] Breakpoint on the first insn of recorded history is not reported in replay Date: Tue, 09 Jan 2024 17:27:46 +0000 [thread overview] Message-ID: <bug-24073-4717-U2NzUc9lsp@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-24073-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=24073 Guinevere Larsen <blarsen at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blarsen at redhat dot com --- Comment #4 from Guinevere Larsen <blarsen at redhat dot com> --- Hi Andrey! Sorry about this going unnoticed for 5 years (My god this is too long a time). Reverse debugging wasn't getting much love at that time, but I've recently been appointed maintainer on this area, so I'd be able to review your patch. Are you still able and interested in contributing to this? If you are, this patch needs a rebase, and needs to use ecs->ws.set_stopped instead of setting the signal and kind manually. It also needs a test in the style of the testsuite (written in TCL), there should be plenty of tests in the gdb/testsuite/gdb.record subdirectory to help (and of course, feel free to reach out in the gdb mailing list). Most importantly, the commit message needs work. Commit logs should usually explain the issue, when applicable an example (in this case I don't really think it's necessary) and explain the solution in general terms. For instance, I expected this patch to always report that the end of story as a breakpoint hit and got really surprise that it doesn't. I think the commit message should explain why. -- You are receiving this mail because: You are on the CC list for the bug.
parent reply other threads:[~2024-01-09 17:27 UTC|newest] Thread overview: expand[flat|nested] mbox.gz Atom feed [parent not found: <bug-24073-4717@http.sourceware.org/bugzilla/>]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-24073-4717-U2NzUc9lsp@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).