[Bug record/24073] Breakpoint on the first insn of recorded history is not reported in replay

[Bug record/24073] Breakpoint on the first insn of recorded history is not reported in replay

[blarsen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24073

Guinevere Larsen <blarsen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |blarsen at redhat dot com

--- Comment #4 from Guinevere Larsen <blarsen at redhat dot com> ---
Hi Andrey!

Sorry about this going unnoticed for 5 years (My god this is too long a time).
Reverse debugging wasn't getting much love at that time, but I've recently been
appointed maintainer on this area, so I'd be able to review your patch. Are you
still able and interested in contributing to this?

If you are, this patch needs a rebase, and needs to use ecs->ws.set_stopped
instead of setting the signal and kind manually. It also needs a test in the
style of the testsuite (written in TCL), there should be plenty of tests in the
gdb/testsuite/gdb.record subdirectory to help (and of course, feel free to
reach out in the gdb mailing list).

Most importantly, the commit message needs work. Commit logs should usually
explain the issue, when applicable an example (in this case I don't really
think it's necessary) and explain the solution in general terms. For instance,
I expected this patch to always report that the end of story as a breakpoint
hit and got really surprise that it doesn't. I think the commit message should
explain why.

-- 
You are receiving this mail because:
You are on the CC list for the bug.