[Bug build/26365] New: [build, arm-elf] Compilation error in sim/arm/wrapper.c

[Bug build/26365] New: [build, arm-elf] Compilation error in sim/arm/wrapper.c

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

            Bug ID: 26365
           Summary: [build, arm-elf] Compilation error in
                    sim/arm/wrapper.c
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

gdb/gdb_mbuild.sh -e arm-elf fails here:
...
src/sim/arm/wrapper.c: In function 'sim_open':
src/sim/arm/wrapper.c:839:31: error: passing argument 1 of
'sim_target_parse_arg_array' discards 'const' qualifier from pointer target
type [-Werror=discarded-qualifiers]
   sim_target_parse_arg_array (argv);
                               ^~~~
src/sim/arm/wrapper.c:744:1: note: expected 'char **' but argument is of type
'char * const*'
 sim_target_parse_arg_array (char ** argv)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
So we have argv:
...
SIM_DESC
sim_open (SIM_OPEN_KIND kind,
          host_callback *cb,
          struct bfd *abfd,
          char * const *argv)
{
...
and then argv is used in this call:
...
  sim_target_parse_arg_array (argv);
...
with prototype:
...
sim_target_parse_arg_array (char ** argv)
...

Looking down further in the implementation in sim_target_parse_command_line:
...
          /* Remove this option from the argv array.  */
          for (arg = i; arg < argc; arg ++)
            argv[arg] = argv[arg + 1];
...
we seem to modifying argv.

OTOH, the sim_open def matches the decl in include/gdb/remote-sim.h:
...
SIM_DESC sim_open (SIM_OPEN_KIND kind, struct host_callback_struct *callback,
                   struct bfd *abfd, char * const *argv);
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alahay01 at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[alahay01 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

Alan Hayward <alahay01 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis.machado at linaro dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Luis Machado <luis.machado at linaro dot org> ---
I recall having fixed this, but then running into the ugliness of sim code.

I'll investigate it again... but the GDB simulators are not well maintained.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |luis.machado at linaro dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

--- Comment #3 from Luis Machado <luis.machado at linaro dot org> ---
Correction, the GDB ARM/AArch64 simulators.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |arm-elf

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

--- Comment #4 from Luis Machado <luis.machado at linaro dot org> ---
The most obvious ugly thing to do is to force-cast the argv argument.

Something less ugly would be to copy argv over and then operate on that
instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vapier at gentoo dot org
          Component|build                       |sim

--- Comment #5 from Luis Machado <luis.machado at linaro dot org> ---
Patch sent.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Luis Machado <luisgpm@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a5353ae6cf1716c0ff6f7037dc3c336f0d99ecc1

commit a5353ae6cf1716c0ff6f7037dc3c336f0d99ecc1
Author: Luis Machado <luis.machado@linaro.org>
Date:   Thu Aug 13 10:32:52 2020 -0300

    [ARM, sim] Fix build failure with -Werror (PR26365)

    There is a bit of a situation in the ARM sim with regards to the handling
    of argv. sim_open () gets a const char **argv, but ARM's sim_open gets
    clever and decides to modify argv in place via
sim_target_parse_command_line.
    I'm not sure why.

    In any case, here's a fix that makes the code modify a copy of argv
instead.

    sim/arm/ChangeLog:

    2020-08-13  Luis Machado  <luis.machado@linaro.org>

            PR sim/26365

            * wrapper.c (sim_target_parse_command_line): Free discarded argv
            entries.
            (sim_open): Use a duplicate of argv instead of the original argv.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug sim/26365] [build, arm-elf] Compilation error in sim/arm/wrapper.c

[luis.machado at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26365

Luis Machado <luis.machado at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Luis Machado <luis.machado at linaro dot org> ---
Fixed now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.