[Bug gdb/26761] thread.c:95: internal-error: thread_info* inferior_thread(): Assertion `current_thread_ != nullptr' failed

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=26761

--- Comment #22 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kevin Buettner <kevinb@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=96e3f4e3c32865fecdb266c2a41532337c75e316

commit 96e3f4e3c32865fecdb266c2a41532337c75e316
Author: Kevin Buettner <kevinb@redhat.com>
Date:   Mon Feb 27 16:11:37 2023 -0700

    Forced quit cases handled by resetting sync_quit_force_run

    During my audit of the use of gdb_exception with regard to QUIT
    processing, I found a try/catch in the scoped_switch_fork_info
    destructor.

    Static analysis found this call path from the destructor to
    maybe_quit():

      scoped_switch_fork_info::~scoped_switch_fork_info()
        -> remove_breakpoints()
        -> remove_breakpoint(bp_location*)
        -> remove_breakpoint_1(bp_location*, remove_bp_reason)
        -> memory_validate_breakpoint(gdbarch*, bp_target_info*)
        -> target_read_memory(unsigned long, unsigned char*, long)
        -> target_read(target_ops*, target_object, char const*, unsigned char*,
unsigned long, long)
        -> maybe_quit()

    Since it's not safe to do a 'throw' from a destructor, we simply
    call set_quit_flag and, for gdb_exception_forced_quit, also
    set sync_quit_force_run.  This will cause the appropriate
    exception to be rethrown at the next QUIT check.

    Another case is the try / catch in tui_getc() in tui-io.c.  The
    existing catch swallows the exception.  I've added a catch for
    'gdb_exception_forced_quit', which also swallows the exception,
    but also sets sync_quit_force_run and calls set_quit_flag in
    order to restart forced quit processing at the next QUIT check.
    This is required because it isn't safe to throw into/through
    readline.

    Thanks to Pedro Alves for suggesting this idea.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=26761
    Tested-by: Tom de Vries <tdevries@suse.de>
    Approved-By: Pedro Alves <pedro@palves.net>

-- 
You are receiving this mail because:
You are on the CC list for the bug.