public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug gdb/26761] thread.c:95: internal-error: thread_info* inferior_thread(): Assertion `current_thread_ != nullptr' failed Date: Mon, 27 Feb 2023 23:21:28 +0000 [thread overview] Message-ID: <bug-26761-4717-qQHpT3r4rm@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-26761-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=26761 --- Comment #16 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Kevin Buettner <kevinb@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=63509715af867d635ad0e8cfe5a662bfc67b4ddf commit 63509715af867d635ad0e8cfe5a662bfc67b4ddf Author: Kevin Buettner <kevinb@redhat.com> Date: Mon Feb 27 16:11:37 2023 -0700 Handle gdb SIGTERM by throwing / catching gdb_exception_force_quit When a GDB process receives the SIGTERM signal, handle_sigterm() in event-top.c is called. The global variable 'sync_quit_force_run' is set by this signal handler. It does some other things too, but the setting of this global is the important bit for the SIGTERM part of this discussion. GDB will periodically check to see whether a Ctrl-C or SIGTERM has been received. This is performed via use of the QUIT macro in GDB's code. QUIT is defined to invoke maybe_quit(), which will be periodically called during any lengthy operation. This is supposed to ensure that the user won't have to wait too long for a Ctrl-C or SIGTERM to be acted upon. When a Ctrl-C / SIGINT is received, quit_handler() will decide whether to pass the SIGINT onto the inferior or to call quit() which causes gdb_exception_quit to be thrown. This exception (usually) propagates to the top level. Control is then returned to the top level event loop. At the moment, SIGTERM is handled very differently. Instead of throwing an exception, quit_force() is called. This does eventually cause GDB to exit(), but prior to that happening, the inferiors are killed or detached and other target related cleanup occurs. As shown in this discussion between Pedro Alves and myself... https://sourceware.org/pipermail/gdb-patches/2021-July/180802.html https://sourceware.org/pipermail/gdb-patches/2021-July/180902.html https://sourceware.org/pipermail/gdb-patches/2021-July/180903.html ...we found that it is possible for inferior_ptid and current_thread_ to get out of sync. When that happens, the "current_thread_ != nullptr" assertion in inferior_thread() can fail resulting in a GDB internal error. Pedro recommended that we "let the normal quit exception propagate all the way to the top level, and then have the top level call quit_force if sync_quit_force_run is set." However, after the v2 series for this patch set, we tweaked that idea by introducing a new exception for handling SIGTERM. This commit implements the obvious part of Pedro's suggestion: Instead of calling quit_force from quit(), throw_forced_quit() is now called instead. This causes the new exception 'gdb_exception_forced_quit' to be thrown. At the top level, I changed catch_command_errors() and captured_main() to catch gdb_exception_forced_quit and then call quit_force() from the catch block. I also changed start_event_loop() to also catch gdb_exception_forced_quit; while we could also call quit_force() from that catch block, it's sufficient to simply rethrow the exception since it'll be caught by the newly added code in captured_main(). Making these changes fixed the failure / regression that I was seeing for gdb.base/gdb-sigterm.exp when run on a machine with glibc-2.34. However, there are many other paths back to the top level which this test case does not test. I did an audit of all of the try / catch code in GDB in which calls in the try-block might (eventually) call QUIT. I found many cases where gdb_exception_quit and the new gdb_exception_forced_quit will be swallowed. (When using GDB, have you ever hit Ctrl-C and not have it do anything; if so, it could be due to a swallowed gdb_exception_quit in one of the cases I've identified.) The rest of the patches in this series deal with this concern. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=26761 Tested-by: Tom de Vries <tdevries@suse.de> Approved-by: Pedro Alves <pedro@palves.net> -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2023-02-27 23:21 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-20 16:07 [Bug gdb/26761] New: " vries at gcc dot gnu.org 2020-10-20 16:07 ` [Bug gdb/26761] " vries at gcc dot gnu.org 2020-11-25 21:05 ` marcdufresne at laposte dot net 2020-12-13 13:12 ` ddresser at bmc dot com 2020-12-14 19:04 ` simark at simark dot ca 2020-12-14 19:06 ` simark at simark dot ca 2021-02-17 22:34 ` Minima2014 at iCloud dot com 2021-09-16 1:17 ` parke.nexus at gmail dot com 2021-09-19 2:10 ` simark at simark dot ca 2021-09-19 3:43 ` parke.nexus at gmail dot com 2022-09-29 10:02 ` vries at gcc dot gnu.org 2022-09-29 12:07 ` vries at gcc dot gnu.org 2022-09-29 14:24 ` simark at simark dot ca 2022-09-29 14:42 ` vries at gcc dot gnu.org 2022-09-29 14:43 ` vries at gcc dot gnu.org 2022-09-29 15:22 ` vries at gcc dot gnu.org 2022-12-15 14:56 ` tromey at sourceware dot org 2023-02-27 23:21 ` cvs-commit at gcc dot gnu.org 2023-02-27 23:21 ` cvs-commit at gcc dot gnu.org [this message] 2023-02-27 23:21 ` cvs-commit at gcc dot gnu.org 2023-02-27 23:21 ` cvs-commit at gcc dot gnu.org 2023-02-27 23:21 ` cvs-commit at gcc dot gnu.org 2023-02-27 23:21 ` cvs-commit at gcc dot gnu.org 2023-02-27 23:21 ` cvs-commit at gcc dot gnu.org 2023-02-27 23:21 ` cvs-commit at gcc dot gnu.org 2023-03-09 22:44 ` kevinb at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-26761-4717-qQHpT3r4rm@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).