[Bug testsuite/26947] New: gdb.tui/new-layout.exp and tcl 8.5

[Bug testsuite/26947] New: gdb.tui/new-layout.exp and tcl 8.5

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26947

            Bug ID: 26947
           Summary: gdb.tui/new-layout.exp and tcl 8.5
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

In test-case gdb.tui/new-layout.exp we find a test:
...
gdb_test "tui new-layout example src 1}" \
    "Extra '\}' in layout specification"
...
before commit 4d91ddd342b "[gdb/testsuite] Fix unbalanced braces in
gdb.tui/new-layout.exp", and after that commit:
...
gdb_test "tui new-layout example src 1\}" \
    "Extra '\}' in layout specification"
...

The commit was supposed to solve this on SLE-11 with tcl 8.5:
...
(gdb) UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid
command name: }
ERROR: Couldn't send tui new-layout example src 1} to GDB.
UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example src 1}
...
but after the commit, we have the identical:
...
(gdb) UNRESOLVED: gdb.tui/new-layout.exp: testcase aborted due to invalid
command name: }
ERROR: Couldn't send tui new-layout example src 1} to GDB.
UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example src 1}
...

After adding another escape, such that we have:
...
gdb_test "tui new-layout example src 1\\}" \
    "Extra '\}' in layout specification"
...
we get rid of the ERROR/UNRESOLVED, but now have a FAIL:
...
(gdb) tui new-layout example src 1\}^M
Trailing junk at: \}^M
(gdb) FAIL: gdb.tui/new-layout.exp: tui new-layout example src 1\}
...

There's no amount of escapes that makes this go as with tcl 8.6, where we
simply have:
...
(gdb) tui new-layout example src 1}^M
Extra '}' in layout specification^M
(gdb) PASS: gdb.tui/new-layout.exp: tui new-layout example src 1}
...

Using the two-backslash escape variant with tcl 8.6, we get the identical FAIL:
...
(gdb) tui new-layout example src 1\}^M
Trailing junk at: \}^M
(gdb) FAIL: gdb.tui/new-layout.exp: tui new-layout example src 1\}
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26947] gdb.tui/new-layout.exp and tcl 8.5

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26947

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
So, what seems to work is wrapping the offending tests in:
...
if { [tcl_version_at_least 8 6] } {

}
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26947] gdb.tui/new-layout.exp and tcl 8.5

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26947

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2020-December/173987.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26947] gdb.tui/new-layout.exp and tcl 8.5

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26947

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=10067028372e0f50799ec93843490db42c619e39

commit 10067028372e0f50799ec93843490db42c619e39
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Dec 10 23:44:49 2020 +0100

    [gdb/testsuite] Fix gdb.tui/new-layout.exp with tcl 8.5

    In commit 4d91ddd342 "[gdb/testsuite] Fix unbalanced braces in
    gdb.tui/new-layout.exp", I tried to fix a problem with test-case
    gdb.tui/new-layout.exp when running with tcl 8.5.

    However, at that point I only had access to the log containing the failure,
    and unfortunately my patch turned out not to be effective.

    So, finally fix this problem by guarding the problematic code with:
    ...
    if { [tcl_version_at_least 8 6] } { ... }
    ...

    Tested on x86_64-linux, specifically SLE-11 where I ran into the failure.

    gdb/testsuite/ChangeLog:

    2020-12-10  Tom de Vries  <tdevries@suse.de>

            PR testsuite/26947
            * gdb.tui/new-layout.exp: Don't execute tests with unbalanced curly
            braces for tcl 8.5 and earlier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26947] gdb.tui/new-layout.exp and tcl 8.5

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26947

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |11.1

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Committed test-case patch, marking resolved-fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.