public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj
@ 2021-03-08 16:15 vries at gcc dot gnu.org
2021-03-08 16:15 ` [Bug ada/27545] " vries at gcc dot gnu.org
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-08 16:15 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
Bug ID: 27545
Summary: FAIL: gdb.ada/tagged.exp: ptype obj
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: ada
Assignee: unassigned at sourceware dot org
Reporter: vries at gcc dot gnu.org
Target Milestone: ---
A new FAIL showed up:
...
(gdb) ptype obj^M
There is no member named _tag.^M
(gdb) FAIL: gdb.ada/tagged.exp: ptype obj
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
@ 2021-03-08 16:15 ` vries at gcc dot gnu.org
2021-03-08 18:35 ` tromey at sourceware dot org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-08 16:15 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
2021-03-08 16:15 ` [Bug ada/27545] " vries at gcc dot gnu.org
@ 2021-03-08 18:35 ` tromey at sourceware dot org
2021-03-08 19:45 ` tromey at sourceware dot org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tromey at sourceware dot org @ 2021-03-08 18:35 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |tromey at sourceware dot org
--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Sorry about that.
Some internal testing @ AdaCore showed a few other regressions, too.
I'm working on them.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
2021-03-08 16:15 ` [Bug ada/27545] " vries at gcc dot gnu.org
2021-03-08 18:35 ` tromey at sourceware dot org
@ 2021-03-08 19:45 ` tromey at sourceware dot org
2021-03-08 20:11 ` vries at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tromey at sourceware dot org @ 2021-03-08 19:45 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
My testing didn't notice a regression here because it
was failing before:
ptype obj
type = new pck.object with record
C4b: array (1 .. 8) of system.storage_elements.storage_element;
end record
(gdb) FAIL: gdb.ada/tagged.exp: ptype obj
However, I do see that the way it fails has changed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
` (2 preceding siblings ...)
2021-03-08 19:45 ` tromey at sourceware dot org
@ 2021-03-08 20:11 ` vries at gcc dot gnu.org
2021-03-08 20:21 ` vries at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-08 20:11 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
I've bisected this to:
...
d308ba78cfaf7c1b3a8d33ceb66c9a180352b888 is the first bad commit
commit d308ba78cfaf7c1b3a8d33ceb66c9a180352b888
Author: Tom Tromey <tom@tromey.com>
Date: Mon Mar 8 07:27:57 2021 -0700
Convert f-exp.y to use operations
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
` (3 preceding siblings ...)
2021-03-08 20:11 ` vries at gcc dot gnu.org
@ 2021-03-08 20:21 ` vries at gcc dot gnu.org
2021-03-09 17:08 ` tromey at sourceware dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-08 20:21 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #2)
> My testing didn't notice a regression here because it
> was failing before:
>
> ptype obj
> type = new pck.object with record
> C4b: array (1 .. 8) of system.storage_elements.storage_element;
> end record
> (gdb) FAIL: gdb.ada/tagged.exp: ptype obj
>
>
>
> However, I do see that the way it fails has changed.
For me, it went from pass to fail. At
d308ba78cfaf7c1b3a8d33ceb66c9a180352b888^ (so, the commit before things broke)
I have:
...
(gdb) ptype obj^M
type = new pck.object with record^M
width: integer;^M
end record^M
(gdb) PASS: gdb.ada/tagged.exp: ptype obj
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
` (4 preceding siblings ...)
2021-03-08 20:21 ` vries at gcc dot gnu.org
@ 2021-03-09 17:08 ` tromey at sourceware dot org
2021-03-09 17:12 ` tromey at sourceware dot org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tromey at sourceware dot org @ 2021-03-09 17:08 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Tom Tromey from comment #2)
> My testing didn't notice a regression here because it
> was failing before:
This happened because my system gcc-gnat debuginfo was out of date.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
` (5 preceding siblings ...)
2021-03-09 17:08 ` tromey at sourceware dot org
@ 2021-03-09 17:12 ` tromey at sourceware dot org
2021-03-12 18:47 ` tromey at sourceware dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tromey at sourceware dot org @ 2021-03-09 17:12 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |11.1
--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
I have a fix for this that I'll send soon.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
` (6 preceding siblings ...)
2021-03-09 17:12 ` tromey at sourceware dot org
@ 2021-03-12 18:47 ` tromey at sourceware dot org
2021-03-15 12:41 ` cvs-commit at gcc dot gnu.org
2021-03-15 14:51 ` tromey at sourceware dot org
9 siblings, 0 replies; 11+ messages in thread
From: tromey at sourceware dot org @ 2021-03-12 18:47 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
--- Comment #7 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2021-March/176918.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
` (7 preceding siblings ...)
2021-03-12 18:47 ` tromey at sourceware dot org
@ 2021-03-15 12:41 ` cvs-commit at gcc dot gnu.org
2021-03-15 14:51 ` tromey at sourceware dot org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-15 12:41 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9863c3b5fc64eec400ed55792a49c678927a6145
commit 9863c3b5fc64eec400ed55792a49c678927a6145
Author: Tom Tromey <tromey@adacore.com>
Date: Mon Mar 15 06:23:12 2021 -0600
Fix regression in Ada ptype
This fixes PR ada/27545, which points out that a test in
gdb.ada/tagged.exp started failing due to the expression rewrite. I
didn't notice this failure because my system gcc-gnat debuginfo was
out of date, and so the test was already failing in the baseline.
Previously, the OP_VAR_VALUE case in ada_evaluate_subexp ended up
doing a recursive call:
arg1 = evaluate_subexp (nullptr, exp, pos, EVAL_NORMAL);
However, during the rewrite I missed this fact and had the new code
call the superclass implementation.
This patch fixes the bug by changing this code to use a recursive call
instead.
gdb/ChangeLog
2021-03-15 Tom Tromey <tromey@adacore.com>
PR ada/27545:
* ada-lang.c (ada_var_value_operation::evaluate): Use recursive
call for tagged type.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug ada/27545] FAIL: gdb.ada/tagged.exp: ptype obj
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
` (8 preceding siblings ...)
2021-03-15 12:41 ` cvs-commit at gcc dot gnu.org
@ 2021-03-15 14:51 ` tromey at sourceware dot org
9 siblings, 0 replies; 11+ messages in thread
From: tromey at sourceware dot org @ 2021-03-15 14:51 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=27545
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-03-15 14:51 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 16:15 [Bug ada/27545] New: FAIL: gdb.ada/tagged.exp: ptype obj vries at gcc dot gnu.org
2021-03-08 16:15 ` [Bug ada/27545] " vries at gcc dot gnu.org
2021-03-08 18:35 ` tromey at sourceware dot org
2021-03-08 19:45 ` tromey at sourceware dot org
2021-03-08 20:11 ` vries at gcc dot gnu.org
2021-03-08 20:21 ` vries at gcc dot gnu.org
2021-03-09 17:08 ` tromey at sourceware dot org
2021-03-09 17:12 ` tromey at sourceware dot org
2021-03-12 18:47 ` tromey at sourceware dot org
2021-03-15 12:41 ` cvs-commit at gcc dot gnu.org
2021-03-15 14:51 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).