[Bug gdb/27780] New: not report warning when set a breakpoint at invalid address for arm64

[Bug gdb/27780] New: not report warning when set a breakpoint at invalid address for arm64

[wenyan.xin at windriver dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27780

            Bug ID: 27780
           Summary: not report warning when set a breakpoint at invalid
                    address for arm64
           Product: gdb
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: wenyan.xin at windriver dot com
  Target Milestone: ---

we are developing a Gdb Server on VxWorks for arm64.

on gdb client side, I used the following command and got output.

(gdb) b *0
Breakpoint 2 at 0x0
(gdb) c
Continuing.
[Inferior 1 (process 1) exited normally]
(gdb)


Since the 0 address breakpoint is invalid, so the output should be as
following:

(gdb) b *0
Breakpoint 2 at 0x0
(gdb) c
Continuing.
Warning:
Cannot insert breakpoint 2.
Cannot access memory at address 0x0

Command aborted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/27780] not report warning when set a breakpoint at invalid address for arm64

[wenyan.xin at windriver dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27780

--- Comment #1 from wenyan.xin at windriver dot com ---
when set a 0 address breakpoint, our Gdb Server send "E01" to gdb client, and
the function remote_target::insert_breakpoint () in fremote.c file return -1;

In file breakpoint.c the function insert_bp_location() says that it returns -1
for failure, but in this case it return 0;


Any error messages are printed to TMP_ERROR_STREAM; and
DISABLED_BREAKS, and HW_BREAKPOINT_ERROR are used to report problems.
Returns 0 for success, 1 if the bp_location type is not supported or
-1 for failure.

      if (bp_excpt.reason != 0)
        {
          /* Can't set the breakpoint.  */

          /* In some cases, we might not be able to insert a
             breakpoint in a shared library that has already been
             removed, but we have not yet processed the shlib unload
             event.  Unfortunately, some targets that implement
             breakpoint insertion themselves can't tell why the
             breakpoint insertion failed (e.g., the remote target
             doesn't define error codes), so we must treat generic
             errors as memory errors.  */
          if (bp_excpt.reason == RETURN_ERROR
              && (bp_excpt.error == GENERIC_ERROR
                  || bp_excpt.error == MEMORY_ERROR)
              && bl->loc_type == bp_loc_software_breakpoint
              && (solib_name_from_address (bl->pspace, bl->address)
                  || shared_objfile_contains_address_p (bl->pspace,
                                                        bl->address)))
            {
              /* See also: disable_breakpoints_in_shlibs.  */
              bl->shlib_disabled = 1;
              gdb::observers::breakpoint_modified.notify (bl->owner);
              if (!*disabled_breaks)
                {
                  fprintf_unfiltered (tmp_error_stream, 
                                      "Cannot insert breakpoint %d.\n", 
                                      bl->owner->number);
                  fprintf_unfiltered (tmp_error_stream, 
                                      "Temporarily disabling shared "
                                      "library breakpoints:\n");
                }
              *disabled_breaks = 1;
              fprintf_unfiltered (tmp_error_stream,
                                  "breakpoint #%d\n", bl->owner->number);
              return 0;    // is this case it return from here, then this issue
happened.
            }

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/27780] not report warning when set a breakpoint at invalid address for arm64

[wenyan.xin at windriver dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27780

--- Comment #2 from wenyan.xin at windriver dot com ---
in this case, if the function insert_bp_location() in file breakpoint.c return
-1 at line 2747 as following, the Warning: Cannot insert breakpoint 2 can been
output, and this issue gone.



 2724           if (bp_excpt.reason == RETURN_ERROR
 2725               && (bp_excpt.error == GENERIC_ERROR
 2726                   || bp_excpt.error == MEMORY_ERROR)
 2727               && bl->loc_type == bp_loc_software_breakpoint
 2728               && (solib_name_from_address (bl->pspace, bl->address)
 2729                   || shared_objfile_contains_address_p (bl->pspace,
 2730                                                         bl->address)))
 2731             {
 2732               /* See also: disable_breakpoints_in_shlibs.  */
 2733               bl->shlib_disabled = 1;
 2734               gdb::observers::breakpoint_modified.notify (bl->owner);
 2735               if (!*disabled_breaks)
 2736                 {
 2737                   fprintf_unfiltered (tmp_error_stream,
 2738                                       "Cannot insert breakpoint %d.\n",
 2739                                       bl->owner->number);
 2740                   fprintf_unfiltered (tmp_error_stream,
 2741                                       "Temporarily disabling shared "
 2742                                       "library breakpoints:\n");
 2743                 }
 2744               *disabled_breaks = 1;
 2745               fprintf_unfiltered (tmp_error_stream,
 2746                                   "breakpoint #%d\n", bl->owner->number);
 2747               return 0;
 2748             }
 2749           else


thanks very much.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/27780] not report warning when set a breakpoint at invalid address for arm64

[wenyan.xin at windriver dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27780

wenyan.xin at windriver dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wenyan.xin at windriver dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/27780] not report warning when set a breakpoint at invalid address for arm64

[wenyan.xin at windriver dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27780

wenyan.xin at windriver dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/27780] not report warning when set a breakpoint at invalid address for arm64

[luis.machado at arm dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27780

Luis Machado <luis.machado at arm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-11-02
             Status|UNCONFIRMED                 |WAITING
                 CC|                            |luis.machado at arm dot com
     Ever confirmed|0                           |1

--- Comment #3 from Luis Machado <luis.machado at arm dot com> ---
Is this still an issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.