public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug gdb/28312] New: maintenance_show_worker_threads lacks CXX_STD_THREAD guard
@ 2021-09-07 9:20 trass3r at gmail dot com
2021-09-07 16:02 ` [Bug gdb/28312] " cbiesinger at google dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: trass3r at gmail dot com @ 2021-09-07 9:20 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=28312
Bug ID: 28312
Summary: maintenance_show_worker_threads lacks CXX_STD_THREAD
guard
Product: gdb
Version: HEAD
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: trass3r at gmail dot com
Target Milestone: ---
https://github.com/bminor/binutils-gdb/blob/b4d9dd5c3576a8d6b1a59b11f8af1a3a2abd5fdc/gdb/maint.c#L850-L882
On MinGW this fails with:
gdb/maint.c:877:14: error: 'gdb::thread_pool' has not been declared
gdb::thread_pool::g_thread_pool->thread_count ());
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug gdb/28312] maintenance_show_worker_threads lacks CXX_STD_THREAD guard
2021-09-07 9:20 [Bug gdb/28312] New: maintenance_show_worker_threads lacks CXX_STD_THREAD guard trass3r at gmail dot com
@ 2021-09-07 16:02 ` cbiesinger at google dot com
2021-09-08 7:04 ` [Bug build/28312] " vries at gcc dot gnu.org
2021-09-08 7:08 ` vries at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: cbiesinger at google dot com @ 2021-09-07 16:02 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=28312
Christian Biesinger <cbiesinger at google dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cbiesinger at google dot com
--- Comment #1 from Christian Biesinger <cbiesinger at google dot com> ---
does mingw not support std::thread?!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug build/28312] maintenance_show_worker_threads lacks CXX_STD_THREAD guard
2021-09-07 9:20 [Bug gdb/28312] New: maintenance_show_worker_threads lacks CXX_STD_THREAD guard trass3r at gmail dot com
2021-09-07 16:02 ` [Bug gdb/28312] " cbiesinger at google dot com
@ 2021-09-08 7:04 ` vries at gcc dot gnu.org
2021-09-08 7:08 ` vries at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-09-08 7:04 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=28312
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|gdb |build
Resolution|--- |FIXED
Target Milestone|--- |12.1
Status|UNCONFIRMED |RESOLVED
CC| |vries at gcc dot gnu.org
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=42f46152849a2d4bd06a87c2dc795de1f7fc1af7
:
[gdb/build] Fix build with undefined CXX_STD_THREAD
When building gdb on openSUSE Leap 42.3, we trigger the case that
CXX_STD_THREAD is undefined, and run into:
...
gdb/maint.c: In function 'void maintenance_show_worker_threads \
(ui_file*, int, cmd_list_element*, const char*)':
gdb/maint.c:877:14: error: 'gdb::thread_pool' has not been declared
gdb::thread_pool::g_thread_pool->thread_count ());
^
Makefile:1647: recipe for target 'maint.o' failed
make[1]: *** [maint.o] Error 1
...
Fix this by handling the undefined CXX_STD_THREAD case in
maintenance_show_worker_threads, such that we get:
...
$ gdb -q -batch -ex "maint show worker-thread"
The number of worker threads GDB can use is 0.
...
Tested on x86_64-linux.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28312
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug build/28312] maintenance_show_worker_threads lacks CXX_STD_THREAD guard
2021-09-07 9:20 [Bug gdb/28312] New: maintenance_show_worker_threads lacks CXX_STD_THREAD guard trass3r at gmail dot com
2021-09-07 16:02 ` [Bug gdb/28312] " cbiesinger at google dot com
2021-09-08 7:04 ` [Bug build/28312] " vries at gcc dot gnu.org
@ 2021-09-08 7:08 ` vries at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: vries at gcc dot gnu.org @ 2021-09-08 7:08 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=28312
--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Christian Biesinger from comment #1)
> does mingw not support std::thread?!
gdbsupport/common.m4:
...
# Check for std::thread. This does not work on some platforms, like
# mingw and DJGPP.
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-08 7:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 9:20 [Bug gdb/28312] New: maintenance_show_worker_threads lacks CXX_STD_THREAD guard trass3r at gmail dot com
2021-09-07 16:02 ` [Bug gdb/28312] " cbiesinger at google dot com
2021-09-08 7:04 ` [Bug build/28312] " vries at gcc dot gnu.org
2021-09-08 7:08 ` vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).