[Bug gdb/28312] New: maintenance_show_worker_threads lacks CXX_STD_THREAD guard

[Bug gdb/28312] New: maintenance_show_worker_threads lacks CXX_STD_THREAD guard

[trass3r at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28312

            Bug ID: 28312
           Summary: maintenance_show_worker_threads lacks CXX_STD_THREAD
                    guard
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: trass3r at gmail dot com
  Target Milestone: ---

https://github.com/bminor/binutils-gdb/blob/b4d9dd5c3576a8d6b1a59b11f8af1a3a2abd5fdc/gdb/maint.c#L850-L882

On MinGW this fails with:

gdb/maint.c:877:14: error: 'gdb::thread_pool' has not been declared
gdb::thread_pool::g_thread_pool->thread_count ());

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/28312] maintenance_show_worker_threads lacks CXX_STD_THREAD guard

[cbiesinger at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28312

Christian Biesinger <cbiesinger at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbiesinger at google dot com

--- Comment #1 from Christian Biesinger <cbiesinger at google dot com> ---
does mingw not support std::thread?!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/28312] maintenance_show_worker_threads lacks CXX_STD_THREAD guard

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28312

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdb                         |build
         Resolution|---                         |FIXED
   Target Milestone|---                         |12.1
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |vries at gcc dot gnu.org

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=42f46152849a2d4bd06a87c2dc795de1f7fc1af7
:

[gdb/build] Fix build with undefined CXX_STD_THREAD

When building gdb on openSUSE Leap 42.3, we trigger the case that
CXX_STD_THREAD is undefined, and run into:
...
gdb/maint.c: In function 'void maintenance_show_worker_threads \
  (ui_file*, int, cmd_list_element*, const char*)':
gdb/maint.c:877:14: error: 'gdb::thread_pool' has not been declared
         gdb::thread_pool::g_thread_pool->thread_count ());
              ^
Makefile:1647: recipe for target 'maint.o' failed
make[1]: *** [maint.o] Error 1
...

Fix this by handling the undefined CXX_STD_THREAD case in
maintenance_show_worker_threads, such that we get:
...
$ gdb -q -batch -ex "maint show worker-thread"
The number of worker threads GDB can use is 0.
...

Tested on x86_64-linux.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28312

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/28312] maintenance_show_worker_threads lacks CXX_STD_THREAD guard

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28312

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Christian Biesinger from comment #1)
> does mingw not support std::thread?!

gdbsupport/common.m4:
...
  # Check for std::thread.  This does not work on some platforms, like          
  # mingw and DJGPP.                                                           
                   ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.