public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug symtab/29105] new DWARF reader still slow Date: Tue, 01 Nov 2022 20:42:05 +0000 [thread overview] Message-ID: <bug-29105-4717-xoIIP3AX2f@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-29105-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=29105 --- Comment #15 from Tom Tromey <tromey at sourceware dot org> --- I've been debugging this a bit. For the sizeof test, gdb makes an index entry for "short int". This comes directly from the DWARF: <1><bc>: Abbrev Number: 2 (DW_TAG_base_type) <bd> DW_AT_byte_size : 2 <be> DW_AT_encoding : 5 (signed) <bf> DW_AT_name : (indirect string, offset: 0x120): short int lookup_signed_typename first looks for "signed short" though. (top-gdb) up #15 0x00000000007bb408 in lookup_typename (language=0x24c0da0 <c_language_defn>, name=0x7fffffffab50 "signed short", block=0x0, noerr=1) at ../../binutils-gdb/gdb/gdbtypes.c:1700 (top-gdb) up #16 0x00000000007bb5ac in lookup_signed_typename (language=0x24c0da0 <c_language_defn>, name=0x12528f8 "short") at ../../binutils-gdb/gdb/gdbtypes.c:1729 Now, trying this with an older gdb shows that psyms also make these same symbol names: (gdb) maint print psymbols [...] `short int', type, 0x0 I'm not sure why it works in this case and not in the new code. I added a 'maint canonicalize' command and it shows: (gdb) maint canonicalize short No change. (gdb) maint canonicalize short int canonical = short (gdb) maint canonicalize signed short int canonical = short (gdb) maint canonicalize signed short canonical = short That is, one oddity here is that the C++ canonical form for these names differs from what's in the DWARF and what things like lookup_signed_typename expect. Next I'm going to look at canonicalization for C, at least for those types that have multiple spellings. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2022-11-01 20:42 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-29 19:51 [Bug symtab/29105] New: " tromey at sourceware dot org 2022-04-29 20:09 ` [Bug symtab/29105] " tromey at sourceware dot org 2022-05-13 20:56 ` tromey at sourceware dot org 2022-05-13 21:01 ` tromey at sourceware dot org 2022-05-16 18:51 ` tromey at sourceware dot org 2022-05-18 16:12 ` simon.marchi at polymtl dot ca 2022-05-20 1:54 ` simark at simark dot ca 2022-05-20 15:13 ` tromey at sourceware dot org 2022-05-20 15:36 ` simon.marchi at polymtl dot ca 2022-05-20 15:48 ` simon.marchi at polymtl dot ca 2022-05-26 13:49 ` cvs-commit at gcc dot gnu.org 2022-05-26 13:50 ` tromey at sourceware dot org 2022-07-13 16:49 ` tromey at sourceware dot org 2022-09-23 20:23 ` tromey at sourceware dot org 2022-09-23 20:44 ` tromey at sourceware dot org 2022-10-02 0:19 ` brobecker at gnat dot com 2022-10-06 20:44 ` tromey at sourceware dot org 2022-10-24 19:27 ` simon.marchi at polymtl dot ca 2022-11-01 20:42 ` tromey at sourceware dot org [this message] 2022-11-04 20:05 ` tromey at sourceware dot org 2022-11-04 20:10 ` simon.marchi at polymtl dot ca 2022-11-04 21:27 ` tromey at sourceware dot org 2022-11-04 21:28 ` tromey at sourceware dot org 2022-11-04 21:28 ` tromey at sourceware dot org 2022-11-05 1:28 ` simark at simark dot ca 2022-11-07 16:28 ` tromey at sourceware dot org 2022-11-16 0:09 ` tkacvins at gmail dot com 2022-11-16 0:56 ` simark at simark dot ca 2022-11-16 15:07 ` tkacvins at gmail dot com 2022-12-01 16:44 ` cvs-commit at gcc dot gnu.org 2022-12-01 18:18 ` cvs-commit at gcc dot gnu.org 2022-12-01 18:22 ` tromey at sourceware dot org 2022-12-14 10:23 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-29105-4717-xoIIP3AX2f@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).