[Bug symtab/30164] New: Restructure symbol domains

[Bug symtab/30164] New: Restructure symbol domains

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30164

            Bug ID: 30164
           Summary: Restructure symbol domains
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

Right now, symbol domains generally follow C.
That is, there is a domain for tags, some for non-C things
(Fortran stuff), a domain for labels, and then VAR_DOMAIN
for everything else -- types, functions, variables.

This leads to bad results, like bug #30158, where an
attempt to look up a function instead finds a namespace.

I think it would be better to drastically overhaul this code.
There should be many more domains, as many as we think
we'll need.  Types, variables, and functions should all
be separate.  Probably namespaces should also be their own thing.

Then, the symbol lookup functions should accept an enum flag
type of all the domains that should be searched.
This way, the C parser can implement its own semantics by
searching the relevant C domains -- but other language parsers
can do as they like.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/30164] Restructure symbol domains

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30164

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
These values are baked into the .gdb_index format.
That isn't fatal but it does mean the index would be bit
less efficient.

Moving more to .debug_names or changing the format of .gdb_index
would both be options here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/30164] Restructure symbol domains

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30164

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24870


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=24870
[Bug 24870] gdb.lookup_type fails if a name is both a type and a variable
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/30164] Restructure symbol domains

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30164

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I've been slowly working on this.

Lately I've been thinking that perhaps STRUCT_DOMAIN could
be removed.  It's only needed for C and is the source of a
hack in symbol_matches_domain.

Instead, any C-specific type-lookup code could just search
TYPE_DOMAIN and look to see if the type is "tagged".

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/30164] Restructure symbol domains

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30164

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Tom Tromey from comment #2)
> I've been slowly working on this.
> 
> Lately I've been thinking that perhaps STRUCT_DOMAIN could
> be removed.  It's only needed for C and is the source of a
> hack in symbol_matches_domain.

On further reflection, I don't think this will work properly,
because in C it is fine to have a 'struct name' and a typedef
for 'name' that are different -- they really are separate
namespaces.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/30164] Restructure symbol domains

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30164

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
The rot here goes really deep :(

symbol_matches_domain has a C++-specific hack.
(That later was extended to other languages)

However, the stabs reader, and some other readers,
take care to handle the C++ typedef case in a more
principled way: by creating a typedef symbol.
One wonders why this wasn't done for DWARF...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/30164] Restructure symbol domains

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30164

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2023-November/204295.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.