[Bug dap/30474] New: Emit DAP thread-exit event

[Bug dap/30474] New: Emit DAP thread-exit event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30474

            Bug ID: 30474
           Summary: Emit DAP thread-exit event
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

When a thread exits, DAP should emit a Thread event
with "exited" as the reason.  gdb doesn't currently do this.
This may require an additional event in the gdb Python code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30474] Emit DAP thread-exit event

[simon.farre.cx at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30474

Simon Farre <simon.farre.cx at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.farre.cx at gmail dot com

--- Comment #1 from Simon Farre <simon.farre.cx at gmail dot com> ---
(In reply to Tom Tromey from comment #0)
> When a thread exits, DAP should emit a Thread event
> with "exited" as the reason.  gdb doesn't currently do this.
> This may require an additional event in the gdb Python code.

A PR has been sent for this issue, though unfortunately wasn't referenced in
the commit: 

https://sourceware.org/pipermail/gdb-patches/2023-June/200077.html

Simon

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30474] Emit DAP thread-exit event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30474

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I think that patch could go in now, with a couple nits fixed up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30474] Emit DAP thread-exit event

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30474

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Farre <simonfarre@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a18b53a8f68bc4fde9bd64b553f4ea500b30c626

commit a18b53a8f68bc4fde9bd64b553f4ea500b30c626
Author: Simon Farre <simon.farre.cx@gmail.com>
Date:   Mon Jun 5 14:56:54 2023 +0200

    Add thread exited event

    Reports a thread exit according to the DAP spec:
   
https://microsoft.github.io/debug-adapter-protocol/specification#Events_Thread

    This patch requires the ThreadExitedEvent to be checked in,
    in order to work. That patch is found here
https://sourceware.org/pipermail/gdb-patches/2023-June/200071.html

    Formatted correctly using black

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30474

    Approved-By: Tom Tromey <tom@tromey.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30474] Emit DAP thread-exit event

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30474

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.1

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.