public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug dap/30474] New: Emit DAP thread-exit event
@ 2023-05-19 15:10 tromey at sourceware dot org
2023-06-05 13:07 ` [Bug dap/30474] " simon.farre.cx at gmail dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: tromey at sourceware dot org @ 2023-05-19 15:10 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30474
Bug ID: 30474
Summary: Emit DAP thread-exit event
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: dap
Assignee: unassigned at sourceware dot org
Reporter: tromey at sourceware dot org
Target Milestone: ---
When a thread exits, DAP should emit a Thread event
with "exited" as the reason. gdb doesn't currently do this.
This may require an additional event in the gdb Python code.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug dap/30474] Emit DAP thread-exit event
2023-05-19 15:10 [Bug dap/30474] New: Emit DAP thread-exit event tromey at sourceware dot org
@ 2023-06-05 13:07 ` simon.farre.cx at gmail dot com
2023-07-12 15:21 ` tromey at sourceware dot org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: simon.farre.cx at gmail dot com @ 2023-06-05 13:07 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30474
Simon Farre <simon.farre.cx at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |simon.farre.cx at gmail dot com
--- Comment #1 from Simon Farre <simon.farre.cx at gmail dot com> ---
(In reply to Tom Tromey from comment #0)
> When a thread exits, DAP should emit a Thread event
> with "exited" as the reason. gdb doesn't currently do this.
> This may require an additional event in the gdb Python code.
A PR has been sent for this issue, though unfortunately wasn't referenced in
the commit:
https://sourceware.org/pipermail/gdb-patches/2023-June/200077.html
Simon
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug dap/30474] Emit DAP thread-exit event
2023-05-19 15:10 [Bug dap/30474] New: Emit DAP thread-exit event tromey at sourceware dot org
2023-06-05 13:07 ` [Bug dap/30474] " simon.farre.cx at gmail dot com
@ 2023-07-12 15:21 ` tromey at sourceware dot org
2023-08-01 16:15 ` cvs-commit at gcc dot gnu.org
2023-08-01 16:18 ` tromey at sourceware dot org
3 siblings, 0 replies; 5+ messages in thread
From: tromey at sourceware dot org @ 2023-07-12 15:21 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30474
--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
I think that patch could go in now, with a couple nits fixed up.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug dap/30474] Emit DAP thread-exit event
2023-05-19 15:10 [Bug dap/30474] New: Emit DAP thread-exit event tromey at sourceware dot org
2023-06-05 13:07 ` [Bug dap/30474] " simon.farre.cx at gmail dot com
2023-07-12 15:21 ` tromey at sourceware dot org
@ 2023-08-01 16:15 ` cvs-commit at gcc dot gnu.org
2023-08-01 16:18 ` tromey at sourceware dot org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-08-01 16:15 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30474
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Farre <simonfarre@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a18b53a8f68bc4fde9bd64b553f4ea500b30c626
commit a18b53a8f68bc4fde9bd64b553f4ea500b30c626
Author: Simon Farre <simon.farre.cx@gmail.com>
Date: Mon Jun 5 14:56:54 2023 +0200
Add thread exited event
Reports a thread exit according to the DAP spec:
https://microsoft.github.io/debug-adapter-protocol/specification#Events_Thread
This patch requires the ThreadExitedEvent to be checked in,
in order to work. That patch is found here
https://sourceware.org/pipermail/gdb-patches/2023-June/200071.html
Formatted correctly using black
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30474
Approved-By: Tom Tromey <tom@tromey.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug dap/30474] Emit DAP thread-exit event
2023-05-19 15:10 [Bug dap/30474] New: Emit DAP thread-exit event tromey at sourceware dot org
` (2 preceding siblings ...)
2023-08-01 16:15 ` cvs-commit at gcc dot gnu.org
@ 2023-08-01 16:18 ` tromey at sourceware dot org
3 siblings, 0 replies; 5+ messages in thread
From: tromey at sourceware dot org @ 2023-08-01 16:18 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=30474
Tom Tromey <tromey at sourceware dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |14.1
--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-01 16:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 15:10 [Bug dap/30474] New: Emit DAP thread-exit event tromey at sourceware dot org
2023-06-05 13:07 ` [Bug dap/30474] " simon.farre.cx at gmail dot com
2023-07-12 15:21 ` tromey at sourceware dot org
2023-08-01 16:15 ` cvs-commit at gcc dot gnu.org
2023-08-01 16:18 ` tromey at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).