[Bug dap/30691] New: Implement "source" request

[Bug dap/30691] New: Implement "source" request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30691

            Bug ID: 30691
           Summary: Implement "source" request
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

The DAP "source" request tells gdb to send the text of a source file.
This would be handy for the scenario where an IDE launches gdb
on some remote machine.

To implement this, we'd need to fix up a couple of spots
that specify "sourceReference": 0, and also at least one
spot (loadedSources request) that doesn't specify this at all.

We'd probably also need a Python API to something like find_and_open_source.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30691] Implement "source" request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30691

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I went ahead and implemented this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30691] Implement "source" request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30691

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2023-July/201207.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30691] Implement "source" request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30691

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30691] Implement "source" request

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30691

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=13bd1a9175962980a3b0f1c0598698858c72fc04

commit 13bd1a9175962980a3b0f1c0598698858c72fc04
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Jul 27 14:27:05 2023 -0600

    Implement DAP "source" request

    This implements the DAP "source" request.  I renamed the
    "loadedSources" function from "sources" to "loaded_sources" to avoid
    any confusion.  I also moved the loadedSources test to the new
    sources.exp.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30691

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/30691] Implement "source" request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30691

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.