[Bug gdb/31331] Wenum-constexpr-conversion should be fixed, soon treated as a hard error

["carlosgalvezp at gmail dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31331

--- Comment #23 from Carlos Galvez <carlosgalvezp at gmail dot com> ---
Ah, I see. I would argue that behavior on trunk is incorrect, though. A C-style
enum with only positive values has an underlying type which is unsigned, on
this particular compiler. The platform-agnostic way to determine whether an
enum  is signed or not is to use std::is_signed<std::underlying_type<...>>. 

Thus a trait called "IsEnumUnsigned" should correctly return "true" on this
situation, which is why the code compiles in the example with
STEP_OVER_BREAKPOINT. 

An orthogonal problem is integer promotion, which is what I believe to be the
root of the problem. Instead of letting the enum silently be promoted into an
integer, it would be preferable to perform an explicit cast to an integer
suitable for the arithmetic operation at hand.

-- 
You are receiving this mail because:
You are on the CC list for the bug.