public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug gdb/31331] Wenum-constexpr-conversion should be fixed, soon treated as a hard error Date: Tue, 13 Feb 2024 23:54:20 +0000 [thread overview] Message-ID: <bug-31331-4717-oTbLXl3Xlt@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-31331-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=31331 --- Comment #30 from Tom Tromey <tromey at sourceware dot org> --- IIUC the current state is: - there's no way to detect whether an enum has an explicit underlying type - we can't use the current approach to detecting if the underlying type is signed - we can't force an underlying type to be unsigned because it would break the compile plugin ABI - but we can't rely on the underlying type of C-like enums to be unsigned since that is compiler dependent - we can't use the promotion detection since that is too broad It seems to me that there's no need to support a signed enumeration constant in enum-flags. It just isn't useful. So, could all the work be done in an unsigned type that is big enough, and then if the enum is signed, mask off the high bit (and assert that no constant with the high bit set is ever passed in)? For enums with a signed underlying type this would mean sacrificing one flag value. But that seems ok. For unsigned enums it would all stay the same. operator~ could just be defined unconditionally. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2024-02-13 23:54 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-02 20:36 [Bug gdb/31331] New: " carlosgalvezp at gmail dot com 2024-02-03 2:40 ` [Bug gdb/31331] " tromey at sourceware dot org 2024-02-03 21:14 ` tromey at sourceware dot org 2024-02-03 21:30 ` sam at gentoo dot org 2024-02-04 18:10 ` carlosgalvezp at gmail dot com 2024-02-04 18:57 ` simon.marchi at polymtl dot ca 2024-02-04 19:56 ` tromey at sourceware dot org 2024-02-04 19:58 ` tromey at sourceware dot org 2024-02-04 21:02 ` tromey at sourceware dot org 2024-02-04 21:19 ` tromey at sourceware dot org 2024-02-04 21:26 ` carlosgalvezp at gmail dot com 2024-02-05 19:28 ` carlosgalvezp at gmail dot com 2024-02-05 19:29 ` carlosgalvezp at gmail dot com 2024-02-05 19:30 ` carlosgalvezp at gmail dot com 2024-02-05 19:47 ` carlosgalvezp at gmail dot com 2024-02-05 19:53 ` simon.marchi at polymtl dot ca 2024-02-05 20:04 ` carlosgalvezp at gmail dot com 2024-02-05 20:08 ` simon.marchi at polymtl dot ca 2024-02-05 20:09 ` simon.marchi at polymtl dot ca 2024-02-05 20:11 ` simon.marchi at polymtl dot ca 2024-02-05 20:43 ` carlosgalvezp at gmail dot com 2024-02-05 20:55 ` carlosgalvezp at gmail dot com 2024-02-05 21:03 ` carlosgalvezp at gmail dot com 2024-02-05 21:19 ` simon.marchi at polymtl dot ca 2024-02-06 18:32 ` carlosgalvezp at gmail dot com 2024-02-07 20:47 ` carlosgalvezp at gmail dot com 2024-02-11 10:02 ` carlosgalvezp at gmail dot com 2024-02-11 17:16 ` tromey at sourceware dot org 2024-02-11 17:19 ` tromey at sourceware dot org 2024-02-11 18:21 ` carlosgalvezp at gmail dot com 2024-02-11 18:44 ` tromey at sourceware dot org 2024-02-11 20:40 ` carlosgalvezp at gmail dot com 2024-02-13 23:54 ` tromey at sourceware dot org [this message] 2024-03-26 15:37 ` tromey at sourceware dot org 2024-04-16 22:57 ` tromey at sourceware dot org 2024-04-17 10:41 ` carlosgalvezp at gmail dot com 2024-04-20 18:22 ` brobecker at gnat dot com 2024-05-08 22:12 ` carlosgalvezp at gmail dot com 2024-05-10 20:35 ` carlosgalvezp at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-31331-4717-oTbLXl3Xlt@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).