public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "carlosgalvezp at gmail dot com" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug gdb/31331] Wenum-constexpr-conversion should be fixed, soon treated as a hard error Date: Fri, 10 May 2024 20:35:01 +0000 [thread overview] Message-ID: <bug-31331-4717-UPIfGek5VA@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-31331-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=31331 --- Comment #36 from Carlos Galvez <carlosgalvezp at gmail dot com> --- Applying the following diff I believe I can maintain the current behavior without changing any tests. It also serves as documentation of what exactly it does. I've run the test suite a few times and don't notice a change in the numbers, but of course it'd be great if someone more experienced tests this. I also confirm that we still get a compiler error as requested in comment #4. With this in place one can look into refactoring/redesigning to avoid having this at all, hopefully it should be easier to understand. Let me know what you think! --- a/gdbsupport/enum-flags.h +++ b/gdbsupport/enum-flags.h @@ -88,15 +88,26 @@ template<> struct integer_for_size<2, 1> { typedef int16_t type; }; template<> struct integer_for_size<4, 1> { typedef int32_t type; }; template<> struct integer_for_size<8, 1> { typedef int64_t type; }; +template<typename T> +struct enum_will_be_promoted_to_signed_integer +{ + static constexpr bool value = std::is_signed<decltype(~T())>::value; +}; + +template <typename T> +struct enum_has_underlying_small_integer +{ + static constexpr bool value = sizeof(T) < sizeof(int); +}; + template<typename T> struct enum_underlying_type { - DIAGNOSTIC_PUSH - DIAGNOSTIC_IGNORE_ENUM_CONSTEXPR_CONVERSION typedef typename - integer_for_size<sizeof (T), static_cast<bool>(T (-1) < T (0))>::type + integer_for_size<sizeof (T), + enum_will_be_promoted_to_signed_integer<T>::value && + !enum_has_underlying_small_integer<T>::value>::type type; - DIAGNOSTIC_POP }; -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2024-05-10 20:35 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-02 20:36 [Bug gdb/31331] New: " carlosgalvezp at gmail dot com 2024-02-03 2:40 ` [Bug gdb/31331] " tromey at sourceware dot org 2024-02-03 21:14 ` tromey at sourceware dot org 2024-02-03 21:30 ` sam at gentoo dot org 2024-02-04 18:10 ` carlosgalvezp at gmail dot com 2024-02-04 18:57 ` simon.marchi at polymtl dot ca 2024-02-04 19:56 ` tromey at sourceware dot org 2024-02-04 19:58 ` tromey at sourceware dot org 2024-02-04 21:02 ` tromey at sourceware dot org 2024-02-04 21:19 ` tromey at sourceware dot org 2024-02-04 21:26 ` carlosgalvezp at gmail dot com 2024-02-05 19:28 ` carlosgalvezp at gmail dot com 2024-02-05 19:29 ` carlosgalvezp at gmail dot com 2024-02-05 19:30 ` carlosgalvezp at gmail dot com 2024-02-05 19:47 ` carlosgalvezp at gmail dot com 2024-02-05 19:53 ` simon.marchi at polymtl dot ca 2024-02-05 20:04 ` carlosgalvezp at gmail dot com 2024-02-05 20:08 ` simon.marchi at polymtl dot ca 2024-02-05 20:09 ` simon.marchi at polymtl dot ca 2024-02-05 20:11 ` simon.marchi at polymtl dot ca 2024-02-05 20:43 ` carlosgalvezp at gmail dot com 2024-02-05 20:55 ` carlosgalvezp at gmail dot com 2024-02-05 21:03 ` carlosgalvezp at gmail dot com 2024-02-05 21:19 ` simon.marchi at polymtl dot ca 2024-02-06 18:32 ` carlosgalvezp at gmail dot com 2024-02-07 20:47 ` carlosgalvezp at gmail dot com 2024-02-11 10:02 ` carlosgalvezp at gmail dot com 2024-02-11 17:16 ` tromey at sourceware dot org 2024-02-11 17:19 ` tromey at sourceware dot org 2024-02-11 18:21 ` carlosgalvezp at gmail dot com 2024-02-11 18:44 ` tromey at sourceware dot org 2024-02-11 20:40 ` carlosgalvezp at gmail dot com 2024-02-13 23:54 ` tromey at sourceware dot org 2024-03-26 15:37 ` tromey at sourceware dot org 2024-04-16 22:57 ` tromey at sourceware dot org 2024-04-17 10:41 ` carlosgalvezp at gmail dot com 2024-04-20 18:22 ` brobecker at gnat dot com 2024-05-08 22:12 ` carlosgalvezp at gmail dot com 2024-05-10 20:35 ` carlosgalvezp at gmail dot com [this message] 2024-05-19 3:57 ` carlosgalvezp at gmail dot com 2024-05-30 8:00 ` carlosgalvezp at gmail dot com 2024-05-30 16:04 ` simon.marchi at polymtl dot ca 2024-05-30 18:39 ` carlosgalvezp at gmail dot com 2024-06-02 18:41 ` carlosgalvezp at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-31331-4717-UPIfGek5VA@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).