[Bug testsuite/31351] New: [gdb/testsuite] UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb

[Bug testsuite/31351] New: [gdb/testsuite] UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31351

            Bug ID: 31351
           Summary: [gdb/testsuite] UNRESOLVED: gdb.dap/ada-nested.exp:
                    compilation prog.adb
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

I ran the following loop:
...
$ for n in $(seq 1 100); do echo $n; ./test.sh 2>&1 | grep "# of " | sort -u;
cp gdb.log gdb.$n.log; done
...
where test.sh runs the dap tests.

I was surprised to see in the results:
...
$ grep UNRESOLVED: gdb.*.log
gdb.11.log:UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
gdb.29.log:UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
gdb.37.log:UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
gdb.72.log:UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
gdb.78.log:UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
gdb.79.log:UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
...

The test run still produces the same amount of passes (minus one for the
compilation), so the compilation actually went fine (otherwise there wouldn't
be any passes).

When issuing a pass for the compilation, dejagnu changes it into an unresolved.

This is a carry-over of the ERROR seen in gdb.dap/pause.exp (see PR31275),
which is run just before.  

It thought we had fixed carrying over things from one test-case to another, but
it seems in this case we still have that problem.

FTR, running test.sh with bash -x gives:
...
+ make V=1 -O check 'RUNTESTFLAGS=gdb.dap/ada-arrays.exp gdb.dap/ada-nested.exp
gdb.dap/ada-scopes.exp gdb.dap/args-env.exp gdb.dap/assign.exp
gdb.dap/attach.exp gdb.dap/basic-dap.exp gdb.dap/bt-nodebug.exp
gdb.dap/catch-exception.exp gdb.dap/children.exp gdb.dap/cond-bp.exp
gdb.dap/cwd.exp gdb.dap/cxx-exception.exp gdb.dap/eof.exp gdb.dap/frameless.exp
gdb.dap/hover.exp gdb.dap/lazy-string.exp gdb.dap/log-message.exp
gdb.dap/memory.exp gdb.dap/modules.exp gdb.dap/pause.exp gdb.dap/ptrref.exp
gdb.dap/remote-dap.exp gdb.dap/rust-slices.exp gdb.dap/scopes.exp
gdb.dap/sources.exp gdb.dap/stack-format.exp gdb.dap/stop-at-main.exp
gdb.dap/terminate.exp gdb.dap/type_check.exp '
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31351] [gdb/testsuite] UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31351

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2024-February/206852.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31351] [gdb/testsuite] UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31351

--- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=50c6682d74bb1b46ae3e140e107549733c699a44

commit 50c6682d74bb1b46ae3e140e107549733c699a44
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Feb 27 16:24:15 2024 +0100

    [gdb/testsuite] Reset errcnt and warncnt in default_gdb_init

    Say we do:
    ...
    $ make check RUNTESTFLAGS="gdb.dap/ada-nested.exp gdb.dap/pause.exp"
    ...
    and add a perror at the end of pause.exp:
    ...
     dap_shutdown
    +
    +perror "foo"
    ...

    We run into:
    ...
    UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
    ...

    This happens because the perror increases the errcnt, which is not reset at
    the end of the test-case, and consequently the first pass in the following
    test-case is changed into an unresolved.

    Version 1.6.3 of dejagnu contains a fix which produces an unresolved at the
    end of the test-case, which does reset the errcnt, but this is with version
    1.6.1.

    Furthermore, we reset the errcnt in clean_restart, but the pass is produced
    before, so that doesn't help either.

    Fix this by resetting errcnt and warncnt in default_gdb_init.

    Tested on x86_64-linux.

    Approved-By: Tom Tromey <tom@tromey.com>

    PR testsuite/31351
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31351

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/31351] [gdb/testsuite] UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31351

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |15.1

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.