* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
@ 2024-03-20 15:31 ` vries at gcc dot gnu.org
2024-03-20 15:57 ` vries at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-20 15:31 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 15420
--> https://sourceware.org/bugzilla/attachment.cgi?id=15420&action=edit
passing gdb.log (on openSUSE Tumbleweed)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
2024-03-20 15:31 ` [Bug testsuite/31514] " vries at gcc dot gnu.org
@ 2024-03-20 15:57 ` vries at gcc dot gnu.org
2024-03-20 16:37 ` vries at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-20 15:57 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #1)
> Created attachment 15420 [details]
> passing gdb.log (on openSUSE Tumbleweed)
Grepping reveals pck2.adb only:
...
$ egrep "start_subfile: name = .*(pck|pck2)\.adb" ~/gdb.log
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
2024-03-20 15:31 ` [Bug testsuite/31514] " vries at gcc dot gnu.org
2024-03-20 15:57 ` vries at gcc dot gnu.org
@ 2024-03-20 16:37 ` vries at gcc dot gnu.org
2024-03-20 16:38 ` vries at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-20 16:37 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> (In reply to Tom de Vries from comment #1)
> > Created attachment 15420 [details]
> > passing gdb.log (on openSUSE Tumbleweed)
>
> Grepping reveals pck2.adb only:
And in the failing case, no matches at all:
...
$ egrep "start_subfile: name = .*(pck|pck2)\.adb" gdb.log
$
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
` (2 preceding siblings ...)
2024-03-20 16:37 ` vries at gcc dot gnu.org
@ 2024-03-20 16:38 ` vries at gcc dot gnu.org
2024-03-21 7:34 ` vries at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-20 16:38 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Created attachment 15421
--> https://sourceware.org/bugzilla/attachment.cgi?id=15421&action=edit
failing gdb.log (on openSUSE Leap 15.4)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
` (3 preceding siblings ...)
2024-03-20 16:38 ` vries at gcc dot gnu.org
@ 2024-03-21 7:34 ` vries at gcc dot gnu.org
2024-03-21 7:50 ` vries at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-21 7:34 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Installed gcc-13 on Leap 15.4.
Passes with gcc-13, fails with gcc-12, 11, 10, 9, 8 and 7.
With gcc-13, we have pck2.adb, pck2.ads, b~foo.adb and b~foo.ads:
...
$ grep "start_subfile: name = .*tagged-lookup" gdb.log | sort -u
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.adb,
name_for_id =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.ads,
name_for_id =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.ads
[symtab-create] start_subfile: name =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck2.ads, name_for_id =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck2.ads
...
With gcc-12, we have just b~foo.adb and b~foo.ads:
...
$ grep "start_subfile: name = .*tagged-lookup" gdb.log | sort -u
[symtab-create] start_subfile: name =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.adb,
name_for_id =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.ads,
name_for_id =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.ads
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
` (4 preceding siblings ...)
2024-03-21 7:34 ` vries at gcc dot gnu.org
@ 2024-03-21 7:50 ` vries at gcc dot gnu.org
2024-03-21 8:00 ` vries at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-21 7:50 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
With the patch reverted, we have the following.
With gcc-13, we have pck2.adb, pck2.ads, pck.adb, pck.ads, b~foo.adb,
b~foo.ads:
...
$ grep "start_subfile: name = .*tagged-lookup" gdb.log | sort -u
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.adb,
name_for_id =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.ads,
name_for_id =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.ads
[symtab-create] start_subfile: name =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck2.ads, name_for_id =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck2.ads
[symtab-create] start_subfile: name =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck.ads, name_for_id =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck.ads
...
With gcc-12, the same:
...
$ grep "start_subfile: name = .*tagged-lookup" gdb.log | sort -u
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck2.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck.adb,
name_for_id =
/data/vries/gdb/binutils-gdb.git/gdb/testsuite/gdb.ada/tagged-lookup/pck.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.adb,
name_for_id =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.adb
[symtab-create] start_subfile: name =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.ads,
name_for_id =
/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.ada/tagged-lookup/b~foo.ads
[symtab-create] start_subfile: name =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck2.ads, name_for_id =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck2.ads
[symtab-create] start_subfile: name =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck.ads, name_for_id =
/data/vries/gdb/src/gdb/testsuite/gdb.ada/tagged-lookup/pck.ads
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
` (5 preceding siblings ...)
2024-03-21 7:50 ` vries at gcc dot gnu.org
@ 2024-03-21 8:00 ` vries at gcc dot gnu.org
2024-03-25 14:06 ` vries at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-21 8:00 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
Tentative patch:
...
diff --git a/gdb/testsuite/gdb.ada/tagged-lookup.exp
b/gdb/testsuite/gdb.ada/tagged-lookup.exp
index 4bc088ba8d5..3803319c505 100644
--- a/gdb/testsuite/gdb.ada/tagged-lookup.exp
+++ b/gdb/testsuite/gdb.ada/tagged-lookup.exp
@@ -52,7 +52,7 @@ gdb_test_multiple "print *the_local_var" "only one CU
expanded" -lbl {
exp_continue
}
-re -wrap ".* = \\\(n => $decimal\\\)" {
- if {$found_pck + $found_pck2 == 1} {
+ if {$found_pck + $found_pck2 <= 1} {
pass $gdb_test_name
} else {
fail $gdb_test_name
...
It detects the fail with fix reverted for gcc-12 and gcc-13, though not before.
And it make the test pass for gcc-12 and gcc-13 with the fix present.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
` (6 preceding siblings ...)
2024-03-21 8:00 ` vries at gcc dot gnu.org
@ 2024-03-25 14:06 ` vries at gcc dot gnu.org
2024-03-25 14:28 ` cvs-commit at gcc dot gnu.org
2024-03-25 14:29 ` vries at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-25 14:06 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/pipermail/gdb-patches/2024-March/207534.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
` (7 preceding siblings ...)
2024-03-25 14:06 ` vries at gcc dot gnu.org
@ 2024-03-25 14:28 ` cvs-commit at gcc dot gnu.org
2024-03-25 14:29 ` vries at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-03-25 14:28 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--- Comment #9 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=874f4887f0361e953f7098459ae60a5f894d362a
commit 874f4887f0361e953f7098459ae60a5f894d362a
Author: Tom de Vries <tdevries@suse.de>
Date: Mon Mar 25 15:28:35 2024 +0100
[gdb/testsuite] Fix gdb.ada/tagged-lookup.exp with gcc <= 12
With gcc 13, test-case gdb.ada/tagged-lookup.exp passes for me, but with
gcc
12, I get:
...
(gdb) set debug symtab-create 1^M
(gdb) print *the_local_var^M
...
$1 = (n => 2)^M
(gdb) FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
...
The problem is that this fails:
...
-re -wrap ".* = \\\(n => $decimal\\\)" {
if {$found_pck + $found_pck2 == 1} {
pass $gdb_test_name
} else {
fail $gdb_test_name
}
...
because $found_pck == 0 and $found_pck2 == 0.
Indeed, with gcc 13 we have:
...
$ grep "start_subfile: name = .*/tagged-lookup/" gdb.log | sed 's%.*/%%'
b~foo.adb
b~foo.adb
b~foo.adb
b~foo.ads
pck2.adb
pck2.adb
pck2.ads
pck2.adb
pck2.ads
...
and with gcc 12:
...
$ grep "start_subfile: name = .*/tagged-lookup/" gdb.log | sed 's%.*/%%'
b~foo.adb
b~foo.adb
b~foo.adb
b~foo.ads
...
Fix this by checking for "$found_pck + $found_pck2 <= 1" instead.
Tested on x86_64-linux.
Approved-By: Tom Tromey <tom@tromey.com>
PR testsuite/31514
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31514
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug testsuite/31514] [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
2024-03-20 10:24 [Bug testsuite/31514] New: [gdb/testsuite] FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded vries at gcc dot gnu.org
` (8 preceding siblings ...)
2024-03-25 14:28 ` cvs-commit at gcc dot gnu.org
@ 2024-03-25 14:29 ` vries at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: vries at gcc dot gnu.org @ 2024-03-25 14:29 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=31514
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Target Milestone|--- |15.1
Status|NEW |RESOLVED
--- Comment #10 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 11+ messages in thread