public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: David Taylor <dtaylor@emc.com>, gdb@sources.redhat.com
Subject: Re: macros, debug information, and parse_macro_definition
Date: Tue, 22 Apr 2003 20:06:00 -0000	[thread overview]
Message-ID: <1030422200614.ZM22477@localhost.localdomain> (raw)
In-Reply-To: David Taylor <dtaylor@emc.com> "macros, debug information, and parse_macro_definition" (Apr 22, 12:40pm)

On Apr 22, 12:40pm, David Taylor wrote:

> As a result, at some point I will need to call a function which will
> either be identical to or 99% identical to parse_macro_definition.
> So, I'd like to propose that the function parse_macro_definition be
> made non static and that it and its support functions (copy_string,
> dwarf2_macro_malformed_definition_complaint, consume_improper_spaces
> -- all three of which are called *ONLY* by parse_macro_defintion) be
> moved to another file -- since they are not DWARF specific anymore.
> 
> Any objections?  File name?

No objections from me...

> My inclination is to move them to macrotab.c since the function
> parse_macro_defintion calls functions within that file and can be
> thought of as a thin veneer above the functions macro_define_object
> and macro_define_function.
> 
> Comments?

Sounds reasonable to me.

Kevin

  reply	other threads:[~2003-04-22 20:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-22 16:40 David Taylor
2003-04-22 20:06 ` Kevin Buettner [this message]
2003-04-24  3:08 ` Jim Blandy
2003-04-24 15:12   ` David Taylor
2003-04-29 14:55     ` Andrew Cagney
2003-04-29 15:55       ` Daniel Berlin
2003-04-29 16:24         ` Keith Walker
2003-04-29 17:13           ` Daniel Berlin
2003-04-29 16:51       ` David Taylor
2003-05-02 19:21       ` Jim Blandy
2003-05-04 19:41         ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1030422200614.ZM22477@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=dtaylor@emc.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).