From: Kevin Buettner <kevinb@redhat.com>
To: gdb@sources.redhat.com
Subject: register_offset_hack() vs REGISTER_BYTE()
Date: Fri, 02 May 2003 00:38:00 -0000 [thread overview]
Message-ID: <1030502003824.ZM26690@localhost.localdomain> (raw)
I'm seeing the following internal error:
.../frame.c:591: internal-error: Failed to compute the register number
corresponding to 0x296
This is happening because the *addrp value in the following loop (which
is in frame_register() in frame.c)...
for (regnum = 0; regnum < NUM_REGS + NUM_PSEUDO_REGS; regnum++)
{
if (*addrp == register_offset_hack (current_gdbarch, regnum))
{
*realnump = regnum;
return;
}
}
...is set using a value obtained from REGISTER_BYTE(). (See
sentinel_frame_prev_register in sentinel-frame.c.) But the
value obtained from register_offset_hack() was computed by using the
register's virtual type. For this particular architecture (64-bit MIPS),
there are some registers whose virtual size is 4, but which are stored
in an 8-byte container. Hence the discrepancy.
It's not clear to me that the values being returned by register_offset_hack()
are all that useful. These are offsets which would occur if you squeezed
all of the "unused" space out of the registers array.
IMO, the call to register_offset_hack() should be replaced with a call
to REGISTER_BYTE().
Opinions?
Kevin
next reply other threads:[~2003-05-02 0:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-02 0:38 Kevin Buettner [this message]
2003-05-02 0:58 ` Andrew Cagney
2003-05-02 1:09 ` Kevin Buettner
2003-05-02 1:30 ` Andrew Cagney
2003-05-02 22:26 ` Andrew Cagney
2003-05-02 22:57 ` Kevin Buettner
2003-05-02 23:16 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030502003824.ZM26690@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).