public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb@sources.redhat.com
Subject: Re: register_offset_hack() vs REGISTER_BYTE()
Date: Fri, 02 May 2003 22:26:00 -0000	[thread overview]
Message-ID: <3EB2F084.6010203@redhat.com> (raw)
In-Reply-To: <3EB1CA26.5080508@redhat.com>


> Can probably change REGISTER_BYTE to a pre-initialized method with predicate (see DEPRECATED_PC_IN_CALL_DUMMY for an example), and then add a predicate test for it to the above mix.

On second thoughts, and having investigate things a bit further ... 
Doing it would revert any architecture [still] defining REGISTER_BYTE 
(almost all of them) back to using the legacy register cache. 
Consequently I'll instead just add sanity checks to ensure that the 
regcache and REGISTER_BYTE are consistent.

> Sentinel frame should probably also be switched to using register_offset_hack(), instead of REGISTER_BYTE(), so that it is more consistent with the frame code.

Appears to work.

> Sounds like it's time to s/ REGISTER_BYTE / DEPRECATED_REGISTER_BYTE /.  It isn't yet possible to eliminate that macro from the MIPS since it is that hardwired mystery that defines the MIPS remote protocol :-(

...

Andrew


  reply	other threads:[~2003-05-02 22:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-02  0:38 Kevin Buettner
2003-05-02  0:58 ` Andrew Cagney
2003-05-02  1:09   ` Kevin Buettner
2003-05-02  1:30     ` Andrew Cagney
2003-05-02 22:26       ` Andrew Cagney [this message]
2003-05-02 22:57         ` Kevin Buettner
2003-05-02 23:16           ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EB2F084.6010203@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).