From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb@sources.redhat.com
Subject: Re: register_offset_hack() vs REGISTER_BYTE()
Date: Fri, 02 May 2003 00:58:00 -0000 [thread overview]
Message-ID: <3EB1C2C8.5080502@redhat.com> (raw)
In-Reply-To: <1030502003824.ZM26690@localhost.localdomain>
> I'm seeing the following internal error:
>
> .../frame.c:591: internal-error: Failed to compute the register number
> corresponding to 0x296
>
> This is happening because the *addrp value in the following loop (which
> is in frame_register() in frame.c)...
>
> for (regnum = 0; regnum < NUM_REGS + NUM_PSEUDO_REGS; regnum++)
> {
> if (*addrp == register_offset_hack (current_gdbarch, regnum))
> {
> *realnump = regnum;
> return;
> }
> }
>
> ...is set using a value obtained from REGISTER_BYTE(). (See
> sentinel_frame_prev_register in sentinel-frame.c.) But the
> value obtained from register_offset_hack() was computed by using the
> register's virtual type.
Er, for a legacy architecture, register_offset_hack(i) (aka
current_regcache->descr->register_offset) should be REGISTER_BYTE(i).
See init_legacy_regcache_descr.
Sounds like the MIPS is sneeking past:
/* If an old style architecture, fill in the remainder of the
register cache descriptor using the register macros. */
if (!gdbarch_pseudo_register_read_p (gdbarch)
&& !gdbarch_pseudo_register_write_p (gdbarch)
&& !gdbarch_register_type_p (gdbarch))
{
descr->legacy_p = 1;
init_legacy_regcache_descr (gdbarch, descr);
return descr;
}
Andrew
next prev parent reply other threads:[~2003-05-02 0:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-02 0:38 Kevin Buettner
2003-05-02 0:58 ` Andrew Cagney [this message]
2003-05-02 1:09 ` Kevin Buettner
2003-05-02 1:30 ` Andrew Cagney
2003-05-02 22:26 ` Andrew Cagney
2003-05-02 22:57 ` Kevin Buettner
2003-05-02 23:16 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB1C2C8.5080502@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).