public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: gdb@sourceware.org
Subject: Bugs in gdb/testsuite/{README,Makefile.in}
Date: Fri, 2 Oct 2020 13:02:33 +0100	[thread overview]
Message-ID: <20201002120233.GB14696@blade.nx> (raw)

Hi all,

Some but not all of the check* rules in gdb/testsuite/Makefile.in
have dependencies on site.exp, but all of them probably should have.
This means the following will succeed if $RULE is "check", for
example, but fail if $RULE is "check-parallel-racy", and probably
others too:

  mkdir build
  cd build
  ../src/configure ...
  make
  cd gdb/testsuite
  make $RULE

I've fixed this manually in my setup, by running 'make site.exp' under
gdb/testsuite.  I found 'make site.exp' mentioned in gdb/testsuite/README,
but only indirectly: the README file says you can either run make
check from the toplevel build directory, or you can cd into
gdb/testsuite and use runtest after "make site.exp".  Probably that
part of gdb/testsuite/README should also mention that you can use
"make check*" under gdb/testsuite too.  Probably also, the check*
rules that don't depend on site.exp should have a dependency added.
I don't have time to fix either at present, so I'm not volunteering!

Cheers,
Gary

-- 
Gary Benson - he / him / his
Principal Software Engineer, Red Hat


                 reply	other threads:[~2020-10-02 12:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201002120233.GB14696@blade.nx \
    --to=gbenson@redhat.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).